Skip to contentSkip to conversation

hwmon: fix gpio-fan.c build

PATCH Applied Randy Dunlap 2 participants 2 messages Mar 10, 2015 – Mar 11, 2015 Hardware monitoring

lore
Share & tools
lore

Randy Dunlap

author
#0 lore raw

PATCH 1/1 hwmon: fix gpio-fan.c build

From: Randy Dunlap <[email protected]>

Fix build error when CONFIG_THERMAL=m and SENSORS_GPIO_FAN=y by preventing that combination.

Fixes these build errors:

drivers/built-in.o: In function `gpio_fan_remove':
gpio-fan.c:(.text+0x21e97e): undefined reference to thermal_cooling_device_unregister' drivers/built-in.o: In function gpio_fan_probe':
gpio-fan.c:(.text+0x21efbc): undefined reference to `thermal_cooling_device_register'

Signed-off-by Randy Dunlap <[email protected]>
Cc Jean Delvare <[email protected]>
Cc Guenter Roeck <[email protected]>
Cc [email protected]
Cc Simon Guinot <[email protected]>
---
 drivers/hwmon/Kconfig |    1 +
 1 file changed, 1 insertion(+)
drivers/hwmon/Kconfig +1 -0
@@ -510,6 +510,7 @@ config SENSORS_G762
 config SENSORS_GPIO_FAN
 	tristate "GPIO fan"
 	depends on GPIOLIB
+	depends on THERMAL || THERMAL=n
 	help
 	  If you say yes here you get support for fans connected to GPIO lines.

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

maintainer Applied
#1 lore raw
Quoted 25 lines · Randy Dunlap

From: Randy Dunlap <[email protected]>

Fix build error when CONFIG_THERMAL=m and SENSORS_GPIO_FAN=y by preventing that combination.

Fixes these build errors:

drivers/built-in.o: In function `gpio_fan_remove':
gpio-fan.c:(.text+0x21e97e): undefined reference to thermal_cooling_device_unregister' drivers/built-in.o: In function gpio_fan_probe':
gpio-fan.c:(.text+0x21efbc): undefined reference to `thermal_cooling_device_register'

Signed-off-by Randy Dunlap <[email protected]>
Cc Jean Delvare <[email protected]>
Cc Guenter Roeck <[email protected]>
Cc [email protected]
Cc Simon Guinot <[email protected]>
---
  drivers/hwmon/Kconfig |    1 +
  1 file changed, 1 insertion(+)

drivers/hwmon/Kconfig config SENSORS_G762 · line 516

Quoted 7 lines
drivers/hwmon/Kconfig +1 -0
@@ -510,6 +510,7 @@ config SENSORS_G762
  config SENSORS_GPIO_FAN
  	tristate "GPIO fan"
  	depends on GPIOLIB
+	depends on THERMAL || THERMAL=n
  	help
  	  If you say yes here you get support for fans connected to GPIO lines.

Applied, thanks.

I really have to add that combination to my build tests :-(

Guenter

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors