ocfs2: use ENOENT instead of EEXIST when get system file fails

PATCH New Joseph Qi 1 participant 1 message Mar 17, 2015 OCFS2

Share & tools

Joseph Qi

author

2015-03-17 04:05 UTC #0 lore raw

PATCH 1/1 ocfs2: use ENOENT instead of EEXIST when get system file fails

When ocfs2_get_system_file_inode fails, it is obscure to set the return value to -EEXIST. So change it to -ENOENT.

Signed-off-by Joseph Qi <[email protected]>

---
 fs/ocfs2/inode.c | 4 ++--
 fs/ocfs2/namei.c | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

fs/ocfs2/inode.c +2 -2

index 7ff422d..8773ffa 100644
@@ -624,7 +624,7 @@ static int ocfs2_remove_inode(struct inode *inode,
 		ocfs2_get_system_file_inode(osb, INODE_ALLOC_SYSTEM_INODE,
 					    le16_to_cpu(di->i_suballoc_slot));
 	if (!inode_alloc_inode) {
-		status = -EEXIST;
+		status = -ENOENT;
 		mlog_errno(status);
 		goto bail;
 	}

@@ -742,7 +742,7 @@ static int ocfs2_wipe_inode(struct inode *inode,
 							       ORPHAN_DIR_SYSTEM_INODE,
 							       orphaned_slot);
 		if (!orphan_dir_inode) {
-			status = -EEXIST;
+			status = -ENOENT;
 			mlog_errno(status);
 			goto bail;
 		}

fs/ocfs2/namei.c +1 -1

index 4983740..09f90cb 100644
@@ -2808,7 +2808,7 @@ int ocfs2_mv_orphaned_inode_to_new(struct inode *dir,
 						       ORPHAN_DIR_SYSTEM_INODE,
 						       osb->slot_num);
 	if (!orphan_dir_inode) {
-		status = -EEXIST;
+		status = -ENOENT;
 		mlog_errno(status);
 		goto leave;
 	}

Signature · 1 line

1.8.4.3