Skip to contentSkip to conversation

pcspk: Fix I/O port name

PATCH Applied Jan Kiszka 3 participants 3 messages Mar 19, 2015 – Mar 25, 2015

lore
Share & tools
lore

Jan Kiszka

author
#0 lore raw

PATCH 1/1 pcspk: Fix I/O port name

Probably a copy&paste bug. Fixing it helps identifying the device model behind port 0x61.

Signed-off-by Jan Kiszka <[email protected]>
---
 hw/audio/pcspk.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
hw/audio/pcspk.c +1 -1
index 1d81bbe..5266fb5 100644
@@ -167,7 +167,7 @@ static void pcspk_initfn(Object *obj)
 {
     PCSpkState *s = PC_SPEAKER(obj);
 
-    memory_region_init_io(&s->ioport, OBJECT(s), &pcspk_io_ops, s, "elcr", 1);
+    memory_region_init_io(&s->ioport, OBJECT(s), &pcspk_io_ops, s, "pcspk", 1);
 }
 
 static void pcspk_realizefn(DeviceState *dev, Error **errp)
Signature · 1 line
2.1.4
Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Jan Kiszka

Probably a copy&paste bug. Fixing it helps identifying the device model behind port 0x61.

Signed-off-by Jan Kiszka <[email protected]>
---
 hw/audio/pcspk.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by Gonglei <[email protected]>
Quoted 14 lines
hw/audio/pcspk.c +1 -1
index 1d81bbe..5266fb5 100644
@@ -167,7 +167,7 @@ static void pcspk_initfn(Object *obj)
 {
     PCSpkState *s = PC_SPEAKER(obj);
 
-    memory_region_init_io(&s->ioport, OBJECT(s), &pcspk_io_ops, s, "elcr", 1);
+    memory_region_init_io(&s->ioport, OBJECT(s), &pcspk_io_ops, s, "pcspk", 1);
 }
 
 static void pcspk_realizefn(DeviceState *dev, Error **errp)
Applied
#2 lore raw
In reply to Jan Kiszka
Quoted 2 lines · Jan Kiszka

Probably a copy&paste bug. Fixing it helps identifying the device model behind port 0x61.

Applied to -trivial, thank you!

/mjt