Skip to contentSkip to conversation

net: Move the comment about unsettable socket-level options to default clause and update its reference.

PATCH Applied YOSHIFUJI Hideaki/吉藤英明 2 participants 2 messages Mar 23, 2015

Subsystems (3)
Networking Network drivers Sockets
lore
Share & tools
lore

YOSHIFUJI Hideaki/吉藤英明

author
#0 lore raw

PATCH 1/1 net: Move the comment about unsettable socket-level options to default clause and update its reference.

We implement the SO_SNDLOWAT etc not to be settable and return ENOPROTOOPT per 1003.1g 7. Move the comment to appropriate position and update the reference.

Signed-off-by YOSHIFUJI Hideaki <[email protected]>
Signed-off-by YOSHIFUJI Hideaki <[email protected]>
---
 net/core/sock.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
net/core/sock.c +3 -2
index d9f9e48..01a4ebb 100644
@@ -928,8 +928,6 @@ set_rcvbuf:
 			sk->sk_mark = val;
 		break;
 
-		/* We implement the SO_SNDLOWAT etc to
-		   not be settable (1003.1g 5.3) */
 	case SO_RXQ_OVFL:
 		sock_valbool_flag(sk, SOCK_RXQ_OVFL, valbool);
 		break;

@@ -1234,6 +1232,9 @@ int sock_getsockopt(struct socket *sock, int level, int optname,
 		break;
 
 	default:
+		/* We implement the SO_SNDLOWAT etc to not be settable
+		 * (1003.1g 7).
+		 */
 		return -ENOPROTOOPT;
 	}
Signature · 1 line
1.9.1