Skip to contentSkip to conversation

Question on ar->max_num_vdevs and WMI ops config.

DISCUSSION Ben Greear 2 participants 2 messages Mar 30, 2015 – Mar 31, 2015 Qualcomm Atheros ATH10K wireless driver

lore
Share & tools
lore

Ben Greear

author
#0 lore raw

I'm porting forward my changes to the 4.0-rc6 kernel, and I notice something a bit confusing to me.

It seems some upstream patch has added ar->max_num_vdevs and some related fields.

But, in places like this:

static struct sk_buff *ath10k_wmi_op_gen_init(struct ath10k *ar)

{
	struct wmi_init_cmd *cmd;
	struct sk_buff *buf;
	struct wmi_resource_config config = {};
	u32 len, val;

	config.num_vdevs = __cpu_to_le32(TARGET_NUM_VDEVS);
	config.num_peers = __cpu_to_le32(TARGET_NUM_PEERS);
	config.num_offload_peers = __cpu_to_le32(TARGET_NUM_OFFLOAD_PEERS);

We are still using constants instead of ar->max_num_vdevs.

Was this done on purpose for some reason?

It will make my patches to support CT features a bit cleaner if we use the values stored in ar->max_num_vdevs etc.

Thanks,
Ben

Signature · 8 lines
Ben Greear <[email protected]>
Candela Technologies Inc  http://www.candelatech.com


_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k
#1 lore raw
Quoted 20 lines · Ben Greear

I'm porting forward my changes to the 4.0-rc6 kernel, and I notice something a bit confusing to me.

It seems some upstream patch has added ar->max_num_vdevs and some related fields.

But, in places like this:

static struct sk_buff *ath10k_wmi_op_gen_init(struct ath10k *ar)

{
        struct wmi_init_cmd *cmd;
        struct sk_buff *buf;
        struct wmi_resource_config config = {};
        u32 len, val;

        config.num_vdevs = __cpu_to_le32(TARGET_NUM_VDEVS);
        config.num_peers = __cpu_to_le32(TARGET_NUM_PEERS);
        config.num_offload_peers = __cpu_to_le32(TARGET_NUM_OFFLOAD_PEERS);
Quoted 3 lines

We are still using constants instead of ar->max_num_vdevs.

Was this done on purpose for some reason?

An oversight I guess.

Michał

_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k