Skip to contentSkip to conversation

backport fails for brcmfmac

DISCUSSION Arend van Spriel 2 participants 3 messages Apr 12, 2015 – Apr 13, 2015

lore
Share & tools
lore
#0 lore raw

I rebased our internel backports tree to backports/master and now I get the following build error when backporting to 3.13 kernel:

/tmp/brcm-backports-gb8d29dc/drivers/net/wireless/brcm80211/brcmfmac/p2p.c:2315:11: error: ���struct net_device��� has no member named ���name_assign_type���
ifp->ndev->name_assign_type = name_assign_type;

Obviously struct netdevice does not have name_assign_type in older kernels, ie. kernels < 3.17 looking at backport-include/linux/netdevice.h. Just not sure what made this issue come up. The assignment was introduced by:

commit 6bab2e19c5ffd1f21b28c2cabb3801a37b77ae69

Author: Tom Gundersen <[email protected]>
Date:   Wed Mar 18 11:13:39 2015 +0100

cfg80211: pass name_assign_type to rdev_add_virtual_intf()

Probably need to rework brcmfmac code to avoid the assignment and pass the name_assign_type to the alloc_netdev call. If there is an easier way feel free to let me know.

Regards,
Arend

#1 lore raw
Quoted 13 lines · Arend van Spriel

I rebased our internel backports tree to backports/master and now I get the following build error when backporting to 3.13 kernel:

/tmp/brcm-backports-gb8d29dc/drivers/net/wireless/brcm80211/brcmfmac/p2p.c:2315:11:
error: ���struct net_device��� has no member named ���name_assign_type���
ifp->ndev->name_assign_type = name_assign_type;

Obviously struct netdevice does not have name_assign_type in older kernels, ie. kernels < 3.17 looking at backport-include/linux/netdevice.h. Just not sure what made this issue come up. The assignment was introduced by:

commit 6bab2e19c5ffd1f21b28c2cabb3801a37b77ae69

Quoted 8 lines
Author: Tom Gundersen <[email protected]>
Date:   Wed Mar 18 11:13:39 2015 +0100

cfg80211: pass name_assign_type to rdev_add_virtual_intf()

Probably need to rework brcmfmac code to avoid the assignment and pass the name_assign_type to the alloc_netdev call. If there is an easier way feel free to let me know.

I think this name_assign_type member is only used to show how the device name was assigned to the device. See name_assign_type in Documentation/ABI/testing/sysfs-class-net
On kernel versions which do not support this sysfs entry, we can just ignore this new member. I think it is save to just add an "#if linux >= 3.17" around this assignment.

Hauke

#2 lore raw
Quoted 23 lines · Hauke Mehrtens
Quoted 13 lines · Arend van Spriel

I rebased our internel backports tree to backports/master and now I get the following build error when backporting to 3.13 kernel:

/tmp/brcm-backports-gb8d29dc/drivers/net/wireless/brcm80211/brcmfmac/p2p.c:2315:11:
error: ���struct net_device��� has no member named ���name_assign_type���
ifp->ndev->name_assign_type = name_assign_type;

Obviously struct netdevice does not have name_assign_type in older kernels, ie. kernels< 3.17 looking at backport-include/linux/netdevice.h. Just not sure what made this issue come up. The assignment was introduced by:

commit 6bab2e19c5ffd1f21b28c2cabb3801a37b77ae69

Quoted 8 lines
Author: Tom Gundersen<[email protected]>
Date:   Wed Mar 18 11:13:39 2015 +0100

cfg80211: pass name_assign_type to rdev_add_virtual_intf()

Probably need to rework brcmfmac code to avoid the assignment and pass the name_assign_type to the alloc_netdev call. If there is an easier way feel free to let me know.

Quoted 6 lines

I think this name_assign_type member is only used to show how the device name was assigned to the device. See name_assign_type in Documentation/ABI/testing/sysfs-class-net
On kernel versions which do not support this sysfs entry, we can just ignore this new member. I think it is save to just add an "#if linux>= 3.17" around this assignment.

Well. I don't want to do that upstream so that would mean adding a patch in backports that needs to be maintained which I prefer to avoid. I will see whether I can rework the code.

Regards,
Arend