Skip to contentSkip to conversation

DEBUG_RCU vs RCU_DEBUG

DISCUSSION Mathieu Desnoyers 1 participant 2 messages Apr 23, 2015 2 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

----- Original Message -----

Quoted 3 lines

I noticed that urcu-qsbr.h checks for RCU_DEBUG being defined while the rest of
userspace-rcu (0.8.6) checks DEBUG_RCU. Is this a mistake or a cunning plan?

Good catch! Even urcu/static/urcu-qsbr.h has a ifdef based on DEBUG_RCU.

Will rename the urcu-qsbr.[ch] RCU_DEBUG to DEBUG_RCU, and I will define RCU_DEBUG if DEBUG_RCU is defined in qsbr (for backward compat). Fixes pushed into master, stable-0.8 and stable-0.7.

Thanks!

Mathieu

Quoted 8 lines

Ciao, Duncan.

_______________________________________________
lttng-dev mailing list
[email protected]
http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

Signature · 3 lines
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com

A message that is not in the archive (sent off-list or not yet received): [email protected]

#3 lore raw

----- Original Message -----

Quoted 7 lines

----- Original Message -----

Quoted 5 lines

I noticed that urcu-qsbr.h checks for RCU_DEBUG being defined while the rest
of
userspace-rcu (0.8.6) checks DEBUG_RCU. Is this a mistake or a cunning plan?

Quoted 5 lines

Good catch! Even urcu/static/urcu-qsbr.h has a ifdef based on DEBUG_RCU.

Will rename the urcu-qsbr.[ch] RCU_DEBUG to DEBUG_RCU, and I will define RCU_DEBUG if DEBUG_RCU is defined in qsbr (for backward compat).

I rather mean the opposite: we define DEBUG_RCU if RCU_DEBUG is defined.

Thanks,

Mathieu

Quoted 25 lines

Fixes pushed into master, stable-0.8 and stable-0.7.

Thanks!

Mathieu

Quoted 8 lines

Ciao, Duncan.

_______________________________________________
lttng-dev mailing list
[email protected]
http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

--
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com

_______________________________________________
lttng-dev mailing list
[email protected]
http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

Signature · 3 lines
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com