bitbake: fetch2/git: Add URL when latest_revision generates an exception.

PATCH In review Mariano Lopez 2 participants 2 messages Apr 27, 2015 – Apr 28, 2015

Share & tools

Mariano Lopez

author

2015-04-27 16:15 UTC #0 lore raw

PATCH 1/1 bitbake: fetch2/git: Add URL when latest_revision generates an exception.

The URL is not sent when _latest_revision generates and exception. When performing the sanity checks it is not possible to know the URI that failed.

This add the URL when latest_revision generates an exception.

Please disregard previous patch with the same topic.

[YOCTO: #7592]

Signed-off-by Mariano Lopez <[email protected]>

---
 bitbake/lib/bb/fetch2/git.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

bitbake/lib/bb/fetch2/git.py +1 -1

index 0fd9bee..0d91431 100644
@@ -352,7 +352,7 @@ class Git(FetchMethod):
             for l in output.split('\n'):
                 if s in l:
                     return l.split()[0]
-        raise bb.fetch2.FetchError("Unable to resolve '%s' in upstream git repository in git ls-remote output" % ud.unresolvedrev[name])
+        raise bb.fetch2.FetchError("Unable to resolve '%s' in upstream git repository in git ls-remote output for %s" % (ud.unresolvedrev[name], ud.host+ud.path))
 
     def latest_versionstring(self, ud, d):
         """

Signature · 1 line

1.8.4.5

Richard Purdie

2015-04-28 16:46 UTC #1 lore raw

Quoted 7 lines · Mariano Lopez

The URL is not sent when _latest_revision generates and exception. When performing the sanity checks it is not possible to know the URI that failed.
This add the URL when latest_revision generates an exception.
Please disregard previous patch with the same topic.

Please put a message like the above which need not be part of the final commit below the --- separator below.

Quoted 21 lines

[YOCTO: #7592]

Signed-off-by Mariano Lopez <[email protected]>

---
  bitbake/lib/bb/fetch2/git.py | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

bitbake/lib/bb/fetch2/git.py +1 -1

index 0fd9bee..0d91431 100644
@@ -352,7 +352,7 @@ class Git(FetchMethod):
              for l in output.split('\n'):
                  if s in l:
                      return l.split()[0]
-        raise bb.fetch2.FetchError("Unable to resolve '%s' in upstream 
 git repository in git ls-remote output" % ud.unresolvedrev[name])
+        raise bb.fetch2.FetchError("Unable to resolve '%s' in upstream

git repository in git ls-remote output for %s" %
(ud.unresolvedrev[name], ud.host+ud.path))

Quoted 2 lines

def latest_versionstring(self, ud, d):
"""

Sadly I can't get this patch to apply since the mail client you've sent this with has mangled the patch with linewrap and done something ugly to the whitespace.

Cheers,

Richard