Skip to contentSkip to conversation

xfstests/common/renameat2: pass the renameat2 flags from _rename_tests, to _rename_tests_source_dest

PATCH In review shhuiw 1 participant 2 messages May 1, 2015

lore
Share & tools
lore

shhuiw

author
#0 lore raw

PATCH 1/1 xfstests/common/renameat2: pass the renameat2 flags from _rename_tests, to _rename_tests_source_dest

_rename_tests() recognizes the 'flags' arg but doesn't pass it to _rename_tests_source_dest() in old code, thus any 'flags' to renameat2 is missed. Fix the missing.

---
 common/renameat2 | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
common/renameat2 +2 -1
index a335169..df2df2e 100644
@@ -78,6 +78,7 @@ _rename_tests_source_dest()
        local source=$1
        local dest=$2
        local options=$3
+       local flags=$4
 
        for stype in none regu symb dire tree; do
                for dtype in none regu symb dire tree; do
@@ -107,11 +108,11 @@ _rename_tests()
        local flags=$2
 
        #same directory renames
-       _rename_tests_source_dest $testdir/src $testdir/dst     "samedir "
+       _rename_tests_source_dest $testdir/src $testdir/dst     "samedir

" $flags

#cross directory renames
mkdir $testdir/x $testdir/y
- _rename_tests_source_dest $testdir/x/src $testdir/y/dst "crossdir"
+ _rename_tests_source_dest $testdir/x/src $testdir/y/dst
"crossdir" $flags
rmdir $testdir/x $testdir/y
}

Signature · 9 lines
2.1.2




_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
author
#1 lore raw
Quoted 34 lines · shhuiw

_rename_tests() recognizes the 'flags' arg but doesn't pass it to _rename_tests_source_dest() in old code, thus any 'flags' to renameat2 is missed. Fix the missing.

---
 common/renameat2 | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
common/renameat2 +2 -1
index a335169..df2df2e 100644
@@ -78,6 +78,7 @@ _rename_tests_source_dest()
        local source=$1
        local dest=$2
        local options=$3
+       local flags=$4
 
        for stype in none regu symb dire tree; do
                for dtype in none regu symb dire tree; do
@@ -107,11 +108,11 @@ _rename_tests()
        local flags=$2
 
        #same directory renames
-       _rename_tests_source_dest $testdir/src $testdir/dst     "samedir "
+       _rename_tests_source_dest $testdir/src $testdir/dst     "samedir

" $flags

#cross directory renames
mkdir $testdir/x $testdir/y

common/renameat2 +1 -1
-       _rename_tests_source_dest $testdir/x/src $testdir/y/dst "crossdir"
+       _rename_tests_source_dest $testdir/x/src $testdir/y/dst
Quoted 4 lines

"crossdir" $flags
rmdir $testdir/x $testdir/y
}

Sorry, this patch seems get corrupted by my mail client. Will resend it.

Regards,
Sheng-Hui

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs