blkcg: remove redundant code in blkcg_css_free()

PATCH In review Zefan Li 2 participants 2 messages May 4, 2015

Subsystems (3)

Block layer cgroup cgroup blkio

lore

Share & tools

lore

Zefan Li

author

2015-05-04 00:41 UTC #0 lore raw

PATCH 1/1 blkcg: remove redundant code in blkcg_css_free()

The check was needed only when we supported modular cgroup subsystem.

Signed-off-by Zefan Li <[email protected]>

---
 block/blk-cgroup.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

block/blk-cgroup.c +1 -3

index 0ac817b..92b7edd 100644
@@ -814,9 +814,7 @@ static void blkcg_css_offline(struct cgroup_subsys_state *css)
 static void blkcg_css_free(struct cgroup_subsys_state *css)
 {
 	struct blkcg *blkcg = css_to_blkcg(css);
-
-	if (blkcg != &blkcg_root)
-		kfree(blkcg);
+	kfree(blkcg);
 }
 
 static struct cgroup_subsys_state *

Signature · 1 line

1.9.1

Tejun Heo

maintainer Acked-by on v1 1/1

2015-05-04 16:16 UTC #1 lore raw

Quoted 3 lines · Zefan Li

The check was needed only when we supported modular cgroup subsystem.
Signed-off-by Zefan Li <[email protected]>

Acked-by Tejun Heo <[email protected]>

Jens, can you please take this patch or shall I route it through the cgroup tree?

Thanks.

Signature · 1 line

tejun