Skip to contentSkip to conversation

s5p-mfc: sparse warnings

DISCUSSION Hans Verkuil 2 participants 2 messages May 22, 2015 – May 28, 2015 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

Hi Marek, Kamil,

Can someone look at these sparse warnings?

s5p-mfc/s5p_mfc_opr_v5.c:266:23: warning: incorrect type in argument 2 (different address spaces) s5p-mfc/s5p_mfc_opr_v5.c:274:23: warning: incorrect type in argument 1 (different address spaces) s5p-mfc/s5p_mfc_opr_v6.c:1855:23: warning: incorrect type in argument 2 (different address spaces) s5p-mfc/s5p_mfc_opr_v6.c:1865:22: warning: incorrect type in argument 1 (different address spaces)

It all depends on whether this is supposed to be __iomem memory or not.

If it is supposed to be __iomem, then sparse will fail elsewhere (I saw at least one memset).

Regards,

Hans

#1 lore raw

Hello,

Quoted 9 lines · Hans Verkuil

Hi Marek, Kamil,

Can someone look at these sparse warnings?

s5p-mfc/s5p_mfc_opr_v5.c:266:23: warning: incorrect type in argument 2 (different address spaces) s5p-mfc/s5p_mfc_opr_v5.c:274:23: warning: incorrect type in argument 1 (different address spaces) s5p-mfc/s5p_mfc_opr_v6.c:1855:23: warning: incorrect type in argument 2 (different address spaces) s5p-mfc/s5p_mfc_opr_v6.c:1865:22: warning: incorrect type in argument 1 (different address spaces)

Quoted 4 lines

It all depends on whether this is supposed to be __iomem memory or not.

If it is supposed to be __iomem, then sparse will fail elsewhere (I saw at least one memset).

Well, this really looks messy. I will send a fix for it.

Best regards

Signature · 2 lines
Marek Szyprowski, PhD
Samsung R&D Institute Poland