Skip to contentSkip to conversation

signal:remove duplicate code

RFC Richard Weinberger 1 participant 1 message May 25, 2015 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

Am 25.05.2015 um 07:49 schrieb yalin wang:

Quoted 15 lines

__dequeue_signal() is only called by dequeue_signal(), after that, dequeue_signal() will call recalc_sigpending(), this function will set or unset TIF_SIGPENDING bit, so we don't need do this in __dequeue_signal()

---
 kernel/signal.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
kernel/signal.c +0 -0
index 836df8d..de33281 100644

kernel/signal.c static int __dequeue_signal(struct sigpending *pending, sigset_t *mask, · line 587

Quoted 5 lines
kernel/signal.c +0 -2
@@ -583,10 +583,9 @@ static int __dequeue_signal(struct sigpending *pending, sigset_t *mask,
     if (sig) {
         if (current->notifier) {
             if (sigismember(current->notifier_mask, sig)) {
-                if (!(current->notifier)(current->notifier_data)) {
-                    clear_thread_flag(TIF_SIGPENDING);

Here be dragons.
In __dequeue_signal() we clear TIF_SIGPENDING depending on the result of ->notifier().
Did you double check that clearing that flag goes hand in hand with recalc_sigpending()?

Thanks,
//richard