Skip to contentSkip to conversation

Use correct partition names for /dev/mapper

PATCH New Stanislav Brabec 1 participant 1 message May 25, 2015 Util-Linux package

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Use correct partition names for /dev/mapper

The default configuration of multipath-tools appends "-partN" to partition nodes. Follow this conventions and do the same.

It fixes for example fdisk -l /dev/mapper/name_of_the_device.

Note that the current implementation only partially fixes the problem. It does not reflect any udev configuration changes, as udev does not provide any function to return names of future (or current) partitions of a particular device. It also does not fix fdisk -l /dev/dm-0.

---
 libfdisk/src/utils.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
libfdisk/src/utils.c +4 -2
index cc470d9..928c59b 100644
@@ -139,9 +139,11 @@ char *fdisk_partname(const char *dev, size_t partno)
 	}
 
 	/* udev names partitions by appending -partN
-	   e.g. ata-SAMSUNG_SV8004H_0357J1FT712448-part1 */
+	   e.g. ata-SAMSUNG_SV8004H_0357J1FT712448-part1
+	   multipath-tools kpartx.rules also append -partN */
 	if ((strncmp(dev, _PATH_DEV_BYID, sizeof(_PATH_DEV_BYID) - 1) == 0) ||
-	     strncmp(dev, _PATH_DEV_BYPATH, sizeof(_PATH_DEV_BYPATH) - 1) == 0) {
+	     strncmp(dev, _PATH_DEV_BYPATH, sizeof(_PATH_DEV_BYPATH) - 1) == 0 ||
+	     strncmp(dev, "/dev/mapper", sizeof("/dev/mapper") - 1) == 0) {
 	       p = "-part";
 	}
 
Signature · 13 lines
2.4.1

-- 
Best Regards / S pozdravem,

Stanislav Brabec
software developer
---------------------------------------------------------------------
SUSE LINUX, s. r. o.                          e-mail: [email protected]
Lihovarská 1060/12                            tel: +49 911 7405384547
190 00 Praha 9                                 fax:  +420 284 084 001
Czech Republic                                    http://www.suse.cz/
PGP: 830B 40D5 9E05 35D8 5E27 6FA3 717C 209F A04F CD76