:dt-binding:Documents the mbigen bindings
PATCH 4/4 :dt-binding:Documents the mbigen bindings
Add the mbigen msi interrupt controller bindings document
Signed-off-by Ma Jun <[email protected]>
--- Documentation/devicetree/bindings/arm/mbigen.txt | 51 ++++++++++++++++++++++ 1 files changed, 51 insertions(+), 0 deletions(-) create mode 100755 Documentation/devicetree/bindings/arm/mbigen.txt
Documentation/devicetree/bindings/arm/mbigen.txt new file +51 -0
@@ -0,0 +1,51 @@ +Hisilicon mbigen device tree bindings. +======================================= + +Mbigen means: message based interrupt generator. + +MBI is kind of msi interrupt only used on Non-PCI devices. + +To reduce the wired interrupt number connected to GIC, +Hisilicon designed mbigen to collect and generate interrupt. + + +Non-pci devices can connect to mbigen and gnerate the inteerrupt +by wirtting ITS register. + +The mbigen and devices connect to mbigen have the following properties: + + +Mbigen required properties: +------------------------------------------- +-compatible: Should be "hisilicon,mbi-gen" +-msi-parent: should specified the ITS mbigen connected +-interrupt controller: Identifies the node as an interrupt controller +- #interrupt-cells : Specifies the number of cells needed to encode an + interrupt source. The value is 2 for now. +- reg: Specifies the base physical address and size of the ITS + registers. + +Examples: + + mbigen_pa: interrupt-controller at 4c030000 { + compatible = "hisilicon,mbi-gen"; + msi-parent = <&its_pa>; + interrupt-controller; + #interrupt-cells = <2>; + reg = <0x4c030000 0x10000>; + }; + +Device connect to mbigen required properties: +---------------------------------------------------- +-interrupt-parent: Specifies the mbigen node which device connected. +-interrupts:specifies the interrupt source.The first cell is hwirq num, the + second number is trigger type. + +Examples: + usb0: ehci at a1000000 { + compatible = "generic-ehci"; + interrupt-parent = <&mbigen_pa>; + reg = <0xa1000000 0x10000>; + interrupts = <20 4>; + }; +
Signature · 1 line
1.7.1
Quoted 18 lines · majun (F)
Add the mbigen msi interrupt controller bindings document
Signed-off-by Ma Jun <[email protected]>--- Documentation/devicetree/bindings/arm/mbigen.txt | 51 ++++++++++++++++++++++ 1 files changed, 51 insertions(+), 0 deletions(-) create mode 100755 Documentation/devicetree/bindings/arm/mbigen.txtDocumentation/devicetree/bindings/arm/mbigen.txt new file +3
-0@@ -0,0 +1,51 @@ +Hisilicon mbigen device tree bindings. +======================================= +
Documentation/devicetree/bindings/arm/mbigen.txt line 13
Quoted 10 lines
Documentation/devicetree/bindings/arm/mbigen.txt new file +10
-0+Mbigen means: message based interrupt generator. + +MBI is kind of msi interrupt only used on Non-PCI devices. + +To reduce the wired interrupt number connected to GIC, +Hisilicon designed mbigen to collect and generate interrupt. + + +Non-pci devices can connect to mbigen and gnerate the inteerrupt +by wirtting ITS register.
Typos.
Documentation/devicetree/bindings/arm/mbigen.txt line 24
Quoted 11 lines
Documentation/devicetree/bindings/arm/mbigen.txt new file +11
-0+ +The mbigen and devices connect to mbigen have the following properties: + + +Mbigen required properties: +------------------------------------------- +-compatible: Should be "hisilicon,mbi-gen" +-msi-parent: should specified the ITS mbigen connected +-interrupt controller: Identifies the node as an interrupt controller +- #interrupt-cells : Specifies the number of cells needed to encode an + interrupt source. The value is 2 for now.
The precise format of these cells needs to be specified, at this point in the binding document.
Why do you say "The value is 2 for now"? Do you expect this to grow in future? If so, why?
Documentation/devicetree/bindings/arm/mbigen.txt line 26
Quoted 2 lines
Documentation/devicetree/bindings/arm/mbigen.txt new file +2
-0+- reg: Specifies the base physical address and size of the ITS + registers.
This doesn't sound right. This isn't the ITS, so it shouldn't refer to the ITS registers in this manner.
Does the mbigen not have its own set of registers?
Thanks,
Mark.
Quoted 29 lines
Documentation/devicetree/bindings/arm/mbigen.txt new file +25
-0+ +Examples: + + mbigen_pa: interrupt-controller at 4c030000 { + compatible = "hisilicon,mbi-gen"; + msi-parent = <&its_pa>; + interrupt-controller; + #interrupt-cells = <2>; + reg = <0x4c030000 0x10000>; + }; + +Device connect to mbigen required properties: +---------------------------------------------------- +-interrupt-parent: Specifies the mbigen node which device connected. +-interrupts:specifies the interrupt source.The first cell is hwirq num, the + second number is trigger type. + +Examples: + usb0: ehci at a1000000 { + compatible = "generic-ehci"; + interrupt-parent = <&mbigen_pa>; + reg = <0xa1000000 0x10000>; + interrupts = <20 4>; + }; +Signature · 1 line
1.7.1
? 2015/6/1 18:04, Mark Rutland ??:
Quoted 32 lines · majun (F)
Quoted 18 lines
Add the mbigen msi interrupt controller bindings document
Signed-off-by Ma Jun <[email protected]>--- Documentation/devicetree/bindings/arm/mbigen.txt | 51 ++++++++++++++++++++++ 1 files changed, 51 insertions(+), 0 deletions(-) create mode 100755 Documentation/devicetree/bindings/arm/mbigen.txtDocumentation/devicetree/bindings/arm/mbigen.txt new file +3
-0@@ -0,0 +1,51 @@ +Hisilicon mbigen device tree bindings. +======================================= +Documentation/devicetree/bindings/arm/mbigen.txt line 13
Quoted 10 lines
Documentation/devicetree/bindings/arm/mbigen.txt new file +10
-0+Mbigen means: message based interrupt generator. + +MBI is kind of msi interrupt only used on Non-PCI devices. + +To reduce the wired interrupt number connected to GIC, +Hisilicon designed mbigen to collect and generate interrupt. + + +Non-pci devices can connect to mbigen and gnerate the inteerrupt +by wirtting ITS register.Typos.
Quoted 15 lines
Documentation/devicetree/bindings/arm/mbigen.txt line 24
Quoted 11 lines
Documentation/devicetree/bindings/arm/mbigen.txt new file +11
-0+ +The mbigen and devices connect to mbigen have the following properties: + + +Mbigen required properties: +------------------------------------------- +-compatible: Should be "hisilicon,mbi-gen" +-msi-parent: should specified the ITS mbigen connected +-interrupt controller: Identifies the node as an interrupt controller +- #interrupt-cells : Specifies the number of cells needed to encode an + interrupt source. The value is 2 for now.The precise format of these cells needs to be specified, at this point in the binding document.
ok, i will fix this in next version
Quoted 3 lines
Why do you say "The value is 2 for now"? Do you expect this to grow in future? If so, why?
Because the hardware design will be changed in the near future, to compatible with these chips, this value need to change either.
Quoted 11 lines
Documentation/devicetree/bindings/arm/mbigen.txt line 26
Quoted 2 lines
Documentation/devicetree/bindings/arm/mbigen.txt new file +2
-0+- reg: Specifies the base physical address and size of the ITS + registers.This doesn't sound right. This isn't the ITS, so it shouldn't refer to the ITS registers in this manner.
Does the mbigen not have its own set of registers?
Thanks,
Mark.
yes, you are right, it should be mbigen register.
Quoted 32 lines
Quoted 29 lines
Documentation/devicetree/bindings/arm/mbigen.txt new file +25
-0+ +Examples: + + mbigen_pa: interrupt-controller at 4c030000 { + compatible = "hisilicon,mbi-gen"; + msi-parent = <&its_pa>; + interrupt-controller; + #interrupt-cells = <2>; + reg = <0x4c030000 0x10000>; + }; + +Device connect to mbigen required properties: +---------------------------------------------------- +-interrupt-parent: Specifies the mbigen node which device connected. +-interrupts:specifies the interrupt source.The first cell is hwirq num, the + second number is trigger type. + +Examples: + usb0: ehci at a1000000 { + compatible = "generic-ehci"; + interrupt-parent = <&mbigen_pa>; + reg = <0xa1000000 0x10000>; + interrupts = <20 4>; + }; +Signature · 1 line
1.7.1.