Build error in -next due to 'MIPS: ath79: Improve the DDR controller interface'
In next-20150604:
Building mips:ath79_defconfig ... failed
--------------
Error log:
arch/mips/pci/pci-ar71xx.c: In function 'ar71xx_pci_reset':arch/mips/pci/pci-ar71xx.c:321:27: error: 'ath79_ddr_base' undeclared (first use in this function) arch/mips/pci/pci-ar71xx.c:321:27: note: each undeclared identifier is reported only once for each function it appears in arch/mips/pci/pci-ar71xx.c:321:16: warning: unused variable 'ddr_base' [-Wunused-variable]
Guenter
PATCH 1/1 MIPS: pci-ar71xx: Fix left over reference to ath79_ddr_base
The patch 'MIPS: ath79: Improve the DDR controller interface' broke the PCI support as it failed to properly removed the use of the variable 'ath79_ddr_base'. Remove that last reference to fix the build.
--- arch/mips/pci/pci-ar71xx.c | 2 -- 1 file changed, 2 deletions(-)
arch/mips/pci/pci-ar71xx.c +0 -2
@@ -318,8 +318,6 @@ static void ar71xx_pci_irq_init(struct ar71xx_pci_controller *apc)static void ar71xx_pci_reset (void ) { -void __iomem *ddr_base = ath79_ddr_base; -ath79_device_reset_set (AR71XX_RESET_PCI_BUS |AR71XX_RESET_PCI_CORE );mdelay (100 );
Signature · 1 line
2.0.0
PATCH 1/1 MIPS: pci-ar71xx: Fix left over reference to ath79_ddr_base
In reply to Guenter RoeckThe patch 'MIPS: ath79: Improve the DDR controller interface' broke the PCI support as it failed to properly removed the use of the variable 'ath79_ddr_base'. Remove that last reference to fix the build.
--- arch/mips/pci/pci-ar71xx.c | 2 -- 1 file changed, 2 deletions(-)
arch/mips/pci/pci-ar71xx.c +0 -2
@@ -318,8 +318,6 @@ static void ar71xx_pci_irq_init(struct ar71xx_pci_controller *apc)static void ar71xx_pci_reset (void ) { -void __iomem *ddr_base = ath79_ddr_base; -ath79_device_reset_set (AR71XX_RESET_PCI_BUS |AR71XX_RESET_PCI_CORE );mdelay (100 );
Signature · 1 line
2.0.0
Re: [PATCH linux-next] MIPS: pci-ar71xx: Fix left over reference to ath79_ddr_base
Quoted 3 lines · Alban Bedel
The patch 'MIPS: ath79: Improve the DDR controller interface' broke the PCI support as it failed to properly removed the use of the variable '
ath79_ddr_base'. Remove that last reference to fix the build.
Thanks, I folded this into the original patch.
Ralf