Skip to contentSkip to conversation

about .dump_station() callback

DISCUSSION Arend van Spriel 2 participants 5 messages Jun 9, 2015

lore
Share & tools
lore
#0 lore raw

Hi Johannes,

I am looking in get_station() and consequently dump_station() callback for our brcmfmac driver. The latter is called with index. Can I expect this to be starting at 0 and iterate through or can it be requested in any order.

Regards,
Arend

#1 lore raw
Quoted 4 lines · Arend van Spriel

I am looking in get_station() and consequently dump_station() callback for our brcmfmac driver. The latter is called with index. Can I expect this to be starting at 0 and iterate through or can it be requested in any order.

You can expect that, yes.

If it would help, we could instead give the driver one or two pointers to unsigned long values that start out as 0 and can be controlled entirely by the driver?

johannes

#2 lore raw
Quoted 8 lines · Johannes Berg
Quoted 4 lines · Arend van Spriel

I am looking in get_station() and consequently dump_station() callback for our brcmfmac driver. The latter is called with index. Can I expect this to be starting at 0 and iterate through or can it be requested in any order.

You can expect that, yes.

Thanks. Guess it is nl80211.c assuring that. I should have checked that first. See that I have to return -ENOENT when iteration is done.

Quoted 3 lines

If it would help, we could instead give the driver one or two pointers to unsigned long values that start out as 0 and can be controlled entirely by the driver?

Not sure if I understand this. What would those pointers represent?

Regards,
Arend

#3 lore raw
Quoted 2 lines · Arend van Spriel

Thanks. Guess it is nl80211.c assuring that. I should have checked that first. See that I have to return -ENOENT when iteration is done.

Right.

Quoted 5 lines
Quoted 3 lines

If it would help, we could instead give the driver one or two pointers to unsigned long values that start out as 0 and can be controlled entirely by the driver?

Not sure if I understand this. What would those pointers represent?

Well, you could put in there whatever you like :)

Though realistically I wouldn't expect you to put anything other than the sta_idx that you currently get.

johannes

#4 lore raw
Quoted 11 lines · Johannes Berg
Quoted 2 lines · Arend van Spriel

Thanks. Guess it is nl80211.c assuring that. I should have checked that first. See that I have to return -ENOENT when iteration is done.

Right.

Quoted 4 lines
Quoted 3 lines

If it would help, we could instead give the driver one or two pointers to unsigned long values that start out as 0 and can be controlled entirely by the driver?

Quoted 6 lines
Quoted 1 line

Not sure if I understand this. What would those pointers represent?

Well, you could put in there whatever you like :)

Though realistically I wouldn't expect you to put anything other than the sta_idx that you currently get.

Well, I obtain (in ap mode) a list of associated clients and keep that list until iteration is done (or .dump_station() is called with sta_idx == 0). So I am fine with current api.

Regards,
Arend