Skip to contentSkip to conversation

Add netdev name to NL80211_CMD_STOP_AP event?

DISCUSSION Ben Greear 2 participants 5 messages Jun 10, 2015

lore
Share & tools
lore

Ben Greear

author
#0 lore raw

While trying to make 'iw' able to print out something useful for
the 'stop_ap' event, I notice there is not really any human friendly
info in the message (just phy id (which may not match phy name), ifindex, and some other wiphy related numeric ID.

Any reason not to add the netdev name (NL80211_ATTR_IFNAME) to this and related messages?

Thanks,
Ben

Signature · 2 lines
Ben Greear <[email protected]>
Candela Technologies Inc  http://www.candelatech.com
#1 lore raw
Quoted 7 lines · Ben Greear

While trying to make 'iw' able to print out something useful for
the 'stop_ap' event, I notice there is not really any human friendly
info in the message (just phy id (which may not match phy name), ifindex, and some other wiphy related numeric ID.

Any reason not to add the netdev name (NL80211_ATTR_IFNAME) to this and related messages?

We're not really adding that *anywhere*, and you can trivially look it up based on the ifindex, so why bother?

johannes

author
#2 lore raw
Quoted 11 lines · Johannes Berg
Quoted 7 lines · Ben Greear

While trying to make 'iw' able to print out something useful for
the 'stop_ap' event, I notice there is not really any human friendly
info in the message (just phy id (which may not match phy name), ifindex, and some other wiphy related numeric ID.

Any reason not to add the netdev name (NL80211_ATTR_IFNAME) to this and related messages?

We're not really adding that *anywhere*, and you can trivially look it up based on the ifindex, so why bother?

I was thinking netdevice might go away before user-space can decode the message ( I was assuming that on delete you would stop and very shortly after that delete the netdev).

It's a small patch to iw and the kernel as far as I can tell...when I get it working, I'll post for consideration..if you don't want it, I won't complain :)

Thanks,
Ben

Quoted 3 lines

johannes

Signature · 2 lines
Ben Greear <[email protected]>
Candela Technologies Inc  http://www.candelatech.com
#3 lore raw
Quoted 3 lines · Ben Greear

I was thinking netdevice might go away before user-space can decode the message ( I was assuming that on delete you would stop and very shortly after that delete the netdev).

Yeah, but in that case ... does it matter? :)

Quoted 1 line

It's a small patch to iw and the kernel as far as I can tell...

It's small *now*, but if we add it to all events it'll end up pretty big...

johannes

author
#4 lore raw
Quoted 7 lines · Johannes Berg
Quoted 3 lines · Ben Greear

I was thinking netdevice might go away before user-space can decode the message ( I was assuming that on delete you would stop and very shortly after that delete the netdev).

Yeah, but in that case ... does it matter? :)

iw will probably print stack garbage, but that would be fixed easily enough w/out the kernel patch.

Quoted 4 lines
Quoted 1 line

It's a small patch to iw and the kernel as far as I can tell...

It's small *now*, but if we add it to all events it'll end up pretty big...

I'll stick with just the stop_ap cmd for now.

Thanks,
Ben

Signature · 2 lines
Ben Greear <[email protected]>
Candela Technologies Inc  http://www.candelatech.com