Skip to contentSkip to conversation

Build error -in -next due to 'Bluetooth: hci_uart: Support operational speed during setup'

DISCUSSION Guenter Roeck 3 participants 6 messages Jun 15, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

alpha:allmodconfig fails to build in -next with

drivers/bluetooth/hci_ldisc.c: In function 'hci_uart_set_baudrate':
drivers/bluetooth/hci_ldisc.c:276:22: error: 'BOTHER' undeclared

BOTHER is not defined for all architectures and otherwise only used with '#ifdef BOTHER'.

Guenter

maintainer
#1 lore raw

Hi Guenter,

Quoted 7 lines

alpha:allmodconfig fails to build in -next with

drivers/bluetooth/hci_ldisc.c: In function 'hci_uart_set_baudrate':
drivers/bluetooth/hci_ldisc.c:276:22: error: 'BOTHER' undeclared

BOTHER is not defined for all architectures and otherwise only used with '#ifdef BOTHER'.

thanks for the report. Is this something that should be #ifdef at the using side or maybe just fixed for the other architectures.

Regards

Marcel

#2 lore raw
Quoted 4 lines · Marcel Holtmann

Hi Guenter,

Quoted 2 lines

alpha:allmodconfig fails to build in -next with

Quoted 8 lines
Quoted 5 lines

drivers/bluetooth/hci_ldisc.c: In function 'hci_uart_set_baudrate':
drivers/bluetooth/hci_ldisc.c:276:22: error: 'BOTHER' undeclared

BOTHER is not defined for all architectures and otherwise only used with '#ifdef BOTHER'.

thanks for the report. Is this something that should be #ifdef at the using side or maybe just fixed for the other architectures.

So far it has been fixed with #ifdef, and this is the first code which uses it outside drivers/tty. So my first tendency would be to fix it on the user side.

However, looking into it, I think only alpha and avr32 are affected. Let me submit patches against those and see where it goes.

Guenter

#3 lore raw

Hi Guenter,

-----Original Message-----
From: [email protected] [mailto:linux-bluetooth-owner@v= ger.kernel.org] On Behalf Of Guenter Roeck
Sent: Monday, June 15, 2015 10:25 AM
To: Marcel Holtmann
Cc: [email protected]; Frederic Danis; BlueZ development; linux-= [email protected]
Subject: Re: Build error -in -next due to 'Bluetooth: hci_uart: Support ope= rational speed during setup'

Quoted 11 lines · Marcel Holtmann

Hi Guenter,

Quoted 7 lines

alpha:allmodconfig fails to build in -next with

drivers/bluetooth/hci_ldisc.c: In function 'hci_uart_set_baudrate':
drivers/bluetooth/hci_ldisc.c:276:22: error: 'BOTHER' undeclared

BOTHER is not defined for all architectures and otherwise only used with '#ifdef BOTHER'.

thanks for the report. Is this something that should be #ifdef at the usi=

ng side or maybe just fixed for the other architectures.

Quoted 1 line

So far it has been fixed with #ifdef, and this is the first code which uses it outside drivers/tty. So my first tendency would be to fix it on the user side.

However, looking into it, I think only alpha and avr32 are affected. Let me submit patches against those and see where it goes.

IF: The BOTHER flag should not be involved in setting the baud rate at all.=
I've published a patch last week that implements the hci_uart_set_baudrate= properly (in my opinion).

Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" = in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

maintainer
#4 lore raw

Hi Ilya,

Quoted 11 lines
Quoted 10 lines
Quoted 7 lines

alpha:allmodconfig fails to build in -next with

drivers/bluetooth/hci_ldisc.c: In function 'hci_uart_set_baudrate':
drivers/bluetooth/hci_ldisc.c:276:22: error: 'BOTHER' undeclared

BOTHER is not defined for all architectures and otherwise only used with '#ifdef BOTHER'.

thanks for the report. Is this something that should be #ifdef at the using side or maybe just fixed for the other architectures.

Quoted 8 lines

So far it has been fixed with #ifdef, and this is the first code which uses it outside drivers/tty. So my first tendency would be to fix it on the user side.

However, looking into it, I think only alpha and avr32 are affected. Let me submit patches against those and see where it goes.

IF: The BOTHER flag should not be involved in setting the baud rate at all. I've published a patch last week that implements the hci_uart_set_baudrate properly (in my opinion).

can you extract this and just submit that version. We might just take that into hci_ldisc.c right away.

However fixing the #ifdef around BOTHER is useful as well since they look unneeded. At least I can not see a reason why a platform would not define them.

Regards

Marcel

#5 lore raw

Hi Marcel,

-----Original Message-----
From: Marcel Holtmann [mailto:[email protected]]=20
Sent: Monday, June 15, 2015 10:43 AM
To: Ilya Faenson
Cc: Guenter Roeck; [email protected]; Frederic Danis; BlueZ deve= lopment; [email protected]
Subject: Re: Build error -in -next due to 'Bluetooth: hci_uart: Support ope= rational speed during setup'

Hi Ilya,

Quoted 9 lines
Quoted 9 lines
Quoted 7 lines

alpha:allmodconfig fails to build in -next with
=20
drivers/bluetooth/hci_ldisc.c: In function 'hci_uart_set_baudrate':
drivers/bluetooth/hci_ldisc.c:276:22: error: 'BOTHER' undeclared =20
BOTHER is not defined for all architectures and otherwise only used with '#ifdef BOTHER'.

=20
thanks for the report. Is this something that should be #ifdef at the us=

ing side or maybe just fixed for the other architectures.

Quoted 10 lines
Quoted 1 line

=20

=20
So far it has been fixed with #ifdef, and this is the first code which uses it outside drivers/tty. So my first tendency would be to fix it on the user side.
=20
However, looking into it, I think only alpha and avr32 are affected. Let me submit patches against those and see where it goes.
=20
IF: The BOTHER flag should not be involved in setting the baud rate at al=

l. I've published a patch last week that implements the hci_uart_set_baudra= te properly (in my opinion).

can you extract this and just submit that version. We might just take that = into hci_ldisc.c right away.

IF: I've published my version now, thanks.

However fixing the #ifdef around BOTHER is useful as well since they look u= nneeded. At least I can not see a reason why a platform would not define th= em.

Regards

Marcel