crypto: rsa - select on undefined AKCIPHER
Hi Tadeusz,
your commit cfc2bb32b313 ("crypto: rsa - add a new rsa generic implementation") was merged into linux-next today (i.e., next-20150618). It changes the crypto/Kconfig file and adds the CRYPTO_RSA config option:
+config CRYPTO_RSA
+ tristate "RSA algorithm"
+ select AKCIPHER
[...]
The symbol AKCIPHER, however, is not defined in Kconfig. Did you maybe mean CRYPTO_AKCIPHER, which you added in commit 3c339ab83fc0 ("crypto:
akcipher - add PKE API")?
I detected the issue by running undertaker-checkpatch from the Undertaker tool suite (https://undertaker.cs.fau.de) as part of an automated, daily analysis of the most recent linux-next tree. There is also a tool in the Linux tree itself that can detect such issues (scripts/checkkconfigsymbols.py).
Regards,
Andreas
Quoted 15 lines · Andreas Ruprecht
Hi Tadeusz,
your commit
cfc2bb32b313("crypto: rsa - add a new rsa generic implementation") was merged into linux-next today (i.e., next-20150618). It changes thecrypto/Kconfigfile and adds theCRYPTO_RSAconfig option:(quoted diff) +3
-0+config CRYPTO_RSA + tristate "RSA algorithm" + select AKCIPHERThe symbol AKCIPHER, however, is not defined in
Kconfig. Did you maybe meanCRYPTO_AKCIPHER, which you added in commit3c339ab83fc0("crypto:
akcipher - add PKE API")?
Quoted 5 lines
I detected the issue by running undertaker-checkpatch from the Undertaker tool suite (https://undertaker.cs.fau.de) as part of an automated, daily analysis of the most recent linux-next tree. There is also a tool in the Linux tree itself that can detect such issues (
scripts/checkkconfigsymbols.py).
Hi Andreas,
Yes it should have been CRYPTO_AKCIPHER.
Thanks for reporting this.
--- >8 ---
This patch fixes invalid config selection for AKCIPHER
---
crypto/Kconfig +1 -1
@@ -102,7 +102,7 @@ config CRYPTO_AKCIPHER config CRYPTO_RSA tristate "RSA algorithm" - select AKCIPHER + select CRYPTO_AKCIPHER select MPILIB select ASN1 help
Herbert Xu
maintainerQuoted 3 lines · Tadeusz Struk
Yes it should have been
CRYPTO_AKCIPHER.
Thanks for reporting this.
Please resend your patch with a cc to linux-crypto.
Thanks,
Signature · 3 lines
Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt