Skip to contentSkip to conversation

x86: fix -Wsign-compare warnings in uaccess.h

PATCH Toralf Förster 2 participants 2 messages Jun 27, 2015

lore
Share & tools
lore
#0 lore raw
Quoted 1 line

The casts are safe, since those conditions are only evaluated when sz >= 0.

Wouldn't in this case the condition "sz < 0" be superfluously ?

Signature · 2 lines
Toralf
pgp key: 7B1A 07F4 EC82 0F90 D4C2  8936 872A E508 0076 E94E
#1 lore raw

Toralf Förster <[email protected]> писал в своём письме Sat, 27 Jun 2015 22:16:27 +0300:

Quoted 5 lines
Quoted 2 lines

The casts are safe, since those conditions are only evaluated when sz

Quoted 1 line

= 0.

Wouldn't in this case the condition "sz < 0" be superfluously ?

No, sz can be negative. I meant that if sz < 0, then the second halves won't be evaluated (though even if they did, it wouldn't matter).