Skip to contentSkip to conversation

rtl8712:Fix checkpatch warning

PATCH RESEND Superseded Ravi Teja Darbha 3 participants 3 messages Jun 29, 2015 Staging

lore
Share & tools
lore

Ravi Teja Darbha

author
#0 lore raw

PATCH RESEND 1/1 rtl8712:Fix checkpatch warning

Fix line over 80 characters warning.

Signed-off-by Ravi Teja Darbha <[email protected]>
---
 drivers/staging/rtl8712/rtl8712_recv.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rtl8712/rtl8712_recv.c +2 -2
index fcb8c61..4fa2540 100644
@@ -58,8 +58,8 @@ int r8712_init_recv_priv(struct recv_priv *precvpriv, struct _adapter *padapter)
 
     /*init recv_buf*/
     _init_queue(&precvpriv->free_recv_buf_queue);
-    precvpriv->pallocated_recv_buf = kzalloc(NR_RECVBUFF * sizeof(struct recv_buf) + 4,
-                         GFP_ATOMIC);
+    precvpriv->pallocated_recv_buf =
+        kzalloc(NR_RECVBUFF * sizeof(struct recv_buf) + 4, GFP_ATOMIC);
     if (precvpriv->pallocated_recv_buf == NULL)
         return _FAIL;
     precvpriv->precv_buf = precvpriv->pallocated_recv_buf + 4 -
Signature · 1 line
1.9.1
#1 lore raw
Quoted 24 lines · Ravi Teja Darbha

Fix line over 80 characters warning.

Signed-off-by Ravi Teja Darbha <[email protected]>
---
 drivers/staging/rtl8712/rtl8712_recv.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rtl8712/rtl8712_recv.c +2 -3
index fcb8c61..4fa2540 100644
@@ -58,8 +58,8 @@ int r8712_init_recv_priv(struct recv_priv *precvpriv, struct _adapter *padapter)
 
     /*init recv_buf*/
     _init_queue(&precvpriv->free_recv_buf_queue);
-    precvpriv->pallocated_recv_buf = kzalloc(NR_RECVBUFF * sizeof(struct recv_buf) + 4,
-                         GFP_ATOMIC);
+    precvpriv->pallocated_recv_buf =
+        kzalloc(NR_RECVBUFF * sizeof(struct recv_buf) + 4, GFP_ATOMIC);
     if (precvpriv->pallocated_recv_buf == NULL)
         return _FAIL;
     precvpriv->precv_buf = precvpriv->pallocated_recv_buf + 4 -
--
Quoted 1 line

1.9.1

Patch still got messed up. Try using git-send-email instead of thunderbird. Or fix thunderbird not to mess with tab characters.

Frans

maintainer
#2 lore raw
In reply to Ravi Teja Darbha
Quoted 13 lines · Ravi Teja Darbha

Fix line over 80 characters warning.

Signed-off-by Ravi Teja Darbha <[email protected]>
---
 drivers/staging/rtl8712/rtl8712_recv.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rtl8712/rtl8712_recv.c +0 -0
index fcb8c61..4fa2540 100644

drivers/staging/rtl8712/rtl8712_recv.c int r8712_init_recv_priv(struct recv_priv *precvpriv, struct _adapter *padapter) · line 62

Quoted 7 lines
drivers/staging/rtl8712/rtl8712_recv.c +2 -2
@@ -58,8 +58,8 @@ int r8712_init_recv_priv(struct recv_priv *precvpriv, struct _adapter *padapter)
 
     /*init recv_buf*/
     _init_queue(&precvpriv->free_recv_buf_queue);
-    precvpriv->pallocated_recv_buf = kzalloc(NR_RECVBUFF * sizeof(struct recv_buf) + 4,
-                         GFP_ATOMIC);
+    precvpriv->pallocated_recv_buf =
+        kzalloc(NR_RECVBUFF * sizeof(struct recv_buf) + 4, GFP_ATOMIC);

Again, your patch is corrupted. Please test this out by emailing it to yourself first and seeing if it can be applied, instead of sending it out to the world in a broken format.