REVIEW: bttv conversion to v4l2_subdev
Quoted 81 lines
Quoted 46 lines · On Mon, 16 Mar 2009 14:04:19 +0100 (CET) "Hans Verkuil" <[email protected]>…
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Based on this principle, IMO, the probing function should, by
default,
Quoted 5 lines
Quoted 5 lines
Quoted 2 lines
probe
for tvaudio, if it doesn't find another audio device. You mayeventually
Quoted 2 lines
ask
for people to report, to warn us that the board entry is broken,but
Quoted 7 lines
Quoted 7 lines
we
Quoted 1 line
shouln't intentionally break a device that we're almost sure that
requires
Quoted 1 line
tvaudio or tda7432.
OK. In other words it would be better to probe for:
Quoted 8 lines
Quoted 8 lines
1) msp3400
2)msp3400_alt
3) tda7432
4) tvaudioand return as soon as we find a chip. So tvaudio is probed unconditionally, effectively ignoring the
needs_tvaudioflag and only honoring the tvaudio module option (although I'm not sure whetherthat
Quoted 4 lines
Quoted 2 lines
is
still needed in that case).IMO, we should handle the
needs_tvaudiowith a different behaviour:using
Quoted 5 lines
such kind of
glue only when we're sure about the tv audio chips used for a certain board. If
unsure, use the auto probing. Otherwise, we'll probe just that know chip(s) range.I have to admit that I've no idea what you mean. My patch replicates the original behavior of 'modprobe tvaudio' where all i2c addresses are probed
that tvaudio supports (from thenormal_i2carray intvaudio.c). We cannot
do a subset of this since it was never administrated which chip in particular is on the board, just that it is one of the chips supported by
tvaudio.Quoted 3 lines
If you want to be able to select particular devices, then you need to administrate that in the card definitions. That's out of scope of this patch IMHO.
You got my idea wrong. I'm just saying that maybe the better is to have the
default probing behaviour by default.However, if the board has a defined set of tv audio modules that we're sure,
then we may override the automatic loading order.So, the final implementation would be something like:
1) Try the modules that has explicit arguments at modprobe, or that
needs_foo
first;
2) Try the probing way;
3) Give up trying to load an audio driver, printing an error message.If we eventually found any bttv board without any audio driver, then we can add
ano_audiobit field to skip the probing process.Note: since we can't really trust much on what we have (due to the non-standard
ways of probing the drivers, that it is possible with bttv), IMO, that the logic you've implemented, with the adjustments I've proposed seem enough,
but this is just my 2 cents.
Quoted 5 lines
We really need some feedback from the users to be sure if the bttv driver is
properly working with the new logic, to be more certain that this approach is
ok.
I'll redo my bttv tree incorporating all your review comments on Tuesday or Wednesday.
One request: I have a v4l-dvb pull request pending. Can you take a look at that? It does contain the tvaudio change as well: feel free to skip that one if you want me to split that change up into two patches (one for the mute bug fix, and one for the tda9875 merge). But besides build fixes and some housekeeping changes that tree also contains a patch for a new v4l2_device_disconnect function. Both pvrusb2 and my cafe/ov7670 conversion need that to go in first.
Especially Mike Isely is waiting for this to go in so that he can create the pull request for the pvrusb2 conversion. And a very big 'Thank you!' to him for doing that work!
Regards,
Hans
Signature · 1 line
Hans Verkuil - video4linux developer - sponsored by TANDBERG