Skip to contentSkip to conversation

Staging: Android: Fixes TODO file

PATCH In review Sohny Thomas 5 participants 9 messages Jul 1, 2015 – Jul 18, 2015 1 message not in the archive

Subsystems (2)
Staging Kernel janitors
lore
Share & tools
lore

Sohny Thomas

author
#1 lore raw

PATCH v2 1/3 Staging: Android: Fixes TODO file

In reply to a message not in the archive

- removed non-existent issue from TODO file
kuid_t or uid_t not present in staging/android

Signed-of-by Sohny Thomas <[email protected]>

---
drivers/staging/android/TODO | 7 -------

1 file changed, 7 deletions(-)
drivers/staging/android/TODO +0 -10
index 06954cd..b15fb0d 100644
@@ -5,13 +5,6 @@ TODO:
- make sure things build as modules properly
- add proper arch dependencies as needed
- audit userspace interfaces to make sure they are sane
- - kuid_t should never be exposed to user space as it is
- kernel internal type. Data structure for this kuid_t is:
- typedef struct {
- uid_t val;
- } kuid_t;
- - This bug is introduced by Xiong Zhou in the patch bd471258f2e09
- - ("staging: android: logger: use kuid_t instead of uid_t")

Please send patches to Greg Kroah-Hartman <[email protected]> and Cc:
Brian Swetland <[email protected]>

#2 lore raw
Quoted 5 lines · Sohny Thomas

- removed non-existent issue from TODO file
kuid_t or uid_t not present in staging/android

Signed-of-by Sohny Thomas <[email protected]>

s,-of-,-off-,

You can remove the leading dash (-). Could you elaborate on why this issue is non existent?

Thanks,
Frans

author
#3 lore raw
In reply to Frans Klaver
Quoted 11 lines · Frans Klaver
Quoted 5 lines · Sohny Thomas

- removed non-existent issue from TODO file
kuid_t or uid_t not present in staging/android

Signed-of-by Sohny Thomas <[email protected]>

s,-of-,-off-,

You can remove the leading dash (-). Could you elaborate on why this issue is non existent?

Thanks for catching the off. According to the TODO the kuid_t is not present in any files under staging/android So I said its non-existent

Quoted 4 lines

Thanks,
Frans

author
#6 lore raw

PATCH v3 1/1 Staging: Android: Fixes for TODO file

In reply to Sohny Thomas

Removed non-existent issue from TODO file
No instance of kuid_t or uid_t as mentioned by the file is present in staging/android directory

Signed-off-by Sohny Thomas <[email protected]>
---
 drivers/staging/android/TODO | 7 -------
 1 file changed, 7 deletions(-)
drivers/staging/android/TODO +0 -7
index 06954cd..b15fb0d 100644
@@ -5,13 +5,6 @@ TODO:
        - make sure things build as modules properly
        - add proper arch dependencies as needed
        - audit userspace interfaces to make sure they are sane
-       - kuid_t should never be exposed to user space as it is
-          kernel internal type. Data structure for this kuid_t is:
-          typedef struct {
-               uid_t val;
-          } kuid_t;
-       - This bug is introduced by Xiong Zhou in the patch bd471258f2e09
-       - ("staging: android: logger: use kuid_t instead of uid_t")
 
 Please send patches to Greg Kroah-Hartman <[email protected]> and Cc:
 Brian Swetland <[email protected]>
author
#5 lore raw
In reply to Dan Carpenter
Quoted 10 lines · Dan Carpenter
Quoted 5 lines · Sohny Thomas

- removed non-existent issue from TODO file
kuid_t or uid_t not present in staging/android

Signed-of-by Sohny Thomas <[email protected]>

The patch is all mangled. It barely seems to match the description but I can't tell for sure because of the mangling.

I sent an another version, Hope its not mangled now Thanks for your time.

-Sohny

Quoted 4 lines

regards,
dan carpenter

maintainer
#7 lore raw

Re: [PATCH v3 ] Staging: Android: Fixes for TODO file

In reply to Sohny Thomas
Quoted 16 lines · Sohny Thomas

Removed non-existent issue from TODO file
No instance of kuid_t or uid_t as mentioned by the file is present in staging/android directory

Signed-off-by Sohny Thomas <[email protected]>
---
 drivers/staging/android/TODO | 7 -------
 1 file changed, 7 deletions(-)
drivers/staging/android/TODO +0 -0
index 06954cd..b15fb0d 100644
@@ -5,13 +5,6 @@ TODO:
        - make sure things build as modules properly
        - add proper arch dependencies as needed
        - audit userspace interfaces to make sure they are sane

drivers/staging/android/TODO TODO: · line 10

Quoted 10 lines
drivers/staging/android/TODO +0 -7
-       - kuid_t should never be exposed to user space as it is
-          kernel internal type. Data structure for this kuid_t is:
-          typedef struct {
-               uid_t val;
-          } kuid_t;
-       - This bug is introduced by Xiong Zhou in the patch bd471258f2e09
-       - ("staging: android: logger: use kuid_t instead of uid_t")
 
 Please send patches to Greg Kroah-Hartman <[email protected]> and Cc:
 Brian Swetland <[email protected]>

Doesn't apply to the tree :(

author
#8 lore raw

Re: [PATCH v3 ] Staging: Android: Fixes for TODO file

In reply to Sohny Thomas
Quoted 25 lines · Greg KH
Quoted 24 lines · Sohny Thomas

Removed non-existent issue from TODO file
No instance of kuid_t or uid_t as mentioned by the file is present in staging/android directory

Signed-off-by Sohny Thomas <[email protected]>
---
 drivers/staging/android/TODO | 7 -------
 1 file changed, 7 deletions(-)
drivers/staging/android/TODO +0 -7
index 06954cd..b15fb0d 100644
@@ -5,13 +5,6 @@ TODO:
        - make sure things build as modules properly
        - add proper arch dependencies as needed
        - audit userspace interfaces to make sure they are sane
-       - kuid_t should never be exposed to user space as it is
-          kernel internal type. Data structure for this kuid_t is:
-          typedef struct {
-               uid_t val;
-          } kuid_t;
-       - This bug is introduced by Xiong Zhou in the patch bd471258f2e09
-       - ("staging: android: logger: use kuid_t instead of uid_t")
Quoted 4 lines

drivers/staging/android/TODO TODO: · line 10

Quoted 2 lines
drivers/staging/android/TODO +0 -0
 Please send patches to Greg Kroah-Hartman <[email protected]> and Cc:
 Brian Swetland <[email protected]>

Doesn't apply to the tree :(

Uh, Sorry to reply late, you mean this snippet is not part of the tree?

Quoted 1 line
#9 lore raw

Re: [PATCH v3 ] Staging: Android: Fixes for TODO file

In reply to Sohny Thomas
Quoted 28 lines · Sohny Thomas
Quoted 25 lines · Greg KH
Quoted 24 lines · Sohny Thomas

Removed non-existent issue from TODO file
No instance of kuid_t or uid_t as mentioned by the file is present in staging/android directory

Signed-off-by Sohny Thomas <[email protected]>
---
 drivers/staging/android/TODO | 7 -------
 1 file changed, 7 deletions(-)
drivers/staging/android/TODO +0 -7
index 06954cd..b15fb0d 100644
@@ -5,13 +5,6 @@ TODO:
        - make sure things build as modules properly
        - add proper arch dependencies as needed
        - audit userspace interfaces to make sure they are sane
-       - kuid_t should never be exposed to user space as it is
-          kernel internal type. Data structure for this kuid_t is:
-          typedef struct {
-               uid_t val;
-          } kuid_t;
-       - This bug is introduced by Xiong Zhou in the patch bd471258f2e09
-       - ("staging: android: logger: use kuid_t instead of uid_t")
Quoted 5 lines
Quoted 4 lines

drivers/staging/android/TODO TODO: · line 10

Quoted 2 lines
drivers/staging/android/TODO +0 -0
 Please send patches to Greg Kroah-Hartman <[email protected]> and Cc:
 Brian Swetland <[email protected]>

Doesn't apply to the tree :(

Uh, Sorry to reply late, you mean this snippet is not part of the tree?

It means something has changed in the code you have modified, and you need to redo the patch in some way so that it applies to the latest version.

julia