Skip to contentSkip to conversation

IB/ipoib: change init sequence ordering

PATCH In review Joseph Salisbury 3 participants 3 messages Jul 1, 2015 – Jul 2, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 IB/ipoib: change init sequence ordering

Hello,

Please consider including upstream commits be7aa663fc1d9156798f5af3c60e6df45e1fe5de and e135106fac9525352feb8e49077c8f46c3eaf288 in the next v3.19.y-ckt release. They were included mainline as of v4.1-rc1. These commits have been tested and confirmed to resolve
http://bugs.launchpad.net/bugs/1467912 .

commit be7aa663fc1d9156798f5af3c60e6df45e1fe5de

Author: Doug Ledford <[email protected]>
Date:   Sat Feb 21 19:27:00 2015 -0500

IB/ipoib: change init sequence ordering

commit e135106fac9525352feb8e49077c8f46c3eaf288

Author: Doug Ledford <[email protected]>
Date:   Sat Feb 21 19:26:59 2015 -0500

IB/ipoib: factor out ah flushing

The bug reporter states this bug is only happening with the 3.19 kernel, these commits may not be needed in other stable kernels.

Sincerely,

Joseph Salisbury

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

#1 lore raw
Quoted 16 lines · Joseph Salisbury

Hello,

Please consider including upstream commits be7aa663fc1d9156798f5af3c60e6df45e1fe5de and e135106fac9525352feb8e49077c8f46c3eaf288 in the next v3.19.y-ckt release. They were included mainline as of v4.1-rc1. These commits have been tested and confirmed to resolve
http://bugs.launchpad.net/bugs/1467912 .

commit be7aa663fc1d9156798f5af3c60e6df45e1fe5de

Author: Doug Ledford <[email protected]>
Date:   Sat Feb 21 19:27:00 2015 -0500

IB/ipoib: change init sequence ordering

Quoted 8 lines

commit e135106fac9525352feb8e49077c8f46c3eaf288

Author: Doug Ledford <[email protected]>
Date:   Sat Feb 21 19:26:59 2015 -0500

IB/ipoib: factor out ah flushing

The bug reporter states this bug is only happening with the 3.19 kernel, these commits may not be needed in other stable kernels.

I have no objection to these two patches going into a 3.19 stable kernel. They are both stand alone, safe patches.

However, there is no difference in the IPoIB code between 3.18 and 3.19, and I didn't think this bug existed in 3.19 (my commit logs called the work preparatory for upcoming patches). If your testing does in fact show that this is only a 3.19 bug, and 3.18 tests clear, then that means the bug was introduced by some other change in the core kernel (probably in how work queues are scheduled and we likely had a situation where our code worked based upon how they used to be scheduled, but with the change we now need explicit flushes).

In any case, ack from me for these two patches.

Signature · 2 lines
Doug Ledford <[email protected]>
              GPG KeyID: 0E572FDD
#2 lore raw
In reply to Joseph Salisbury
Quoted 16 lines · Joseph Salisbury

Hello,

Please consider including upstream commits be7aa663fc1d9156798f5af3c60e6df45e1fe5de and e135106fac9525352feb8e49077c8f46c3eaf288 in the next v3.19.y-ckt release. They were included mainline as of v4.1-rc1. These commits have been tested and confirmed to resolve
http://bugs.launchpad.net/bugs/1467912 .

commit be7aa663fc1d9156798f5af3c60e6df45e1fe5de

Author: Doug Ledford <[email protected]>
Date:   Sat Feb 21 19:27:00 2015 -0500

IB/ipoib: change init sequence ordering

Quoted 8 lines

commit e135106fac9525352feb8e49077c8f46c3eaf288

Author: Doug Ledford <[email protected]>
Date:   Sat Feb 21 19:26:59 2015 -0500

IB/ipoib: factor out ah flushing

The bug reporter states this bug is only happening with the 3.19 kernel, these commits may not be needed in other stable kernels.

Queued up for 3.19-stable.

And thanks very much for the extra analysis and ack on this, Doug.

-Kamal