Skip to contentSkip to conversation

V4.1-RC build error after commit 77a3c6f

DISCUSSION Larry Finger 2 participants 5 messages Jul 11, 2015 – Jul 13, 2015

lore
Share & tools
lore
#0 lore raw

Beginning with the commit in the subject, I get the following build error:

CC [M] drivers/media/v4l2-core/videobuf2-core.o
drivers/media/v4l2-core/videobuf2-core.c: In function ‘vb2_warn_zero_bytesused’:
drivers/media/v4l2-core/videobuf2-core.c:1253:2: error: implicit declaration of function ‘__WARN’ [-Werror=implicit-function-declaration]
__WARN();
^
cc1: some warnings being treated as errors

My .config is attached.

This problem has been bisected to the following commit:

commit 77a3c6fd90c94f635edb00d4a65f485687538791

Author: Laurent Pinchart <[email protected]>
Date:   Fri Jun 19 08:50:07 2015 -0300

[media] vb2: Don't WARN when v4l2_buffer.bytesused is 0 for multiplanar buffers

Commit f61bf13b6a07 ("[media] vb2: add allow_zero_bytesused flag to the vb2_queue struct") added a WARN_ONCE to catch usage of a deprecated API using a zero value for v4l2_buffer.bytesused.

However, the condition is checked incorrectly, as the v4L2_buffer bytesused field is supposed to be ignored for multiplanar buffers. This results in spurious warnings when using the multiplanar API.

Fix it by checking v4l2_buffer.bytesused for uniplanar buffers and v4l2_plane.bytesused for multiplanar buffers.

Fixes f61bf13b6a07 ("[media] vb2: add allow_zero_bytesused flag to the

vb2_queue struct")

Thanks,

Larry

#1 lore raw

The subject should say V4.2-RC. Sorry.

Larry

Quoted 42 lines · Larry Finger

Beginning with the commit in the subject, I get the following build error:

CC [M] drivers/media/v4l2-core/videobuf2-core.o
drivers/media/v4l2-core/videobuf2-core.c: In function ‘vb2_warn_zero_bytesused’:
drivers/media/v4l2-core/videobuf2-core.c:1253:2: error: implicit declaration of function ‘__WARN’ [-Werror=implicit-function-declaration]

   __WARN();
   ^

cc1: some warnings being treated as errors

My .config is attached.

This problem has been bisected to the following commit:

commit 77a3c6fd90c94f635edb00d4a65f485687538791

Author: Laurent Pinchart <[email protected]>
Date:   Fri Jun 19 08:50:07 2015 -0300

[media] vb2: Don't WARN when v4l2_buffer.bytesused is 0 for multiplanar
buffers

Commit f61bf13b6a07 ("[media] vb2: add allow_zero_bytesused flag to the vb2_queue struct") added a WARN_ONCE to catch usage of a deprecated API using a zero value for v4l2_buffer.bytesused.

However, the condition is checked incorrectly, as the v4L2_buffer bytesused field is supposed to be ignored for multiplanar buffers. This results in spurious warnings when using the multiplanar API.

Fix it by checking v4l2_buffer.bytesused for uniplanar buffers and v4l2_plane.bytesused for multiplanar buffers.

Fixes f61bf13b6a07 ("[media] vb2: add allow_zero_bytesused flag to the

vb2_queue struct")

Thanks,

Larry

#2 lore raw
In reply to Larry Finger

Hi Larry,

Thank you for the report.

Quoted 7 lines · On Saturday 11 July 2015 16:27:36 Larry Finger wrote:

Beginning with the commit in the subject, I get the following build error:

CC [M] drivers/media/v4l2-core/videobuf2-core.o
drivers/media/v4l2-core/videobuf2-core.c: In function ‘vb2_warn_zero_bytesused’: drivers/media/v4l2-core/videobuf2-core.c:1253:2:
error: implicit declaration of function ‘__WARN’ [-Werror=implicit-function-declaration]

Quoted 5 lines
   __WARN();
   ^

cc1: some warnings being treated as errors

My .config is attached.

Indeed, __WARN isn't defined when CONFIG_BUG isn't set. My bad :-/

I've send a patch to fix this (you've been CC'ed), could you please review it ?

And I've just noticed that I forgot to add your Reported-by: tag, please feel free to add it to the review.

Quoted 31 lines

This problem has been bisected to the following commit:

commit 77a3c6fd90c94f635edb00d4a65f485687538791

Author: Laurent Pinchart <[email protected]>
Date:   Fri Jun 19 08:50:07 2015 -0300

[media] vb2: Don't WARN when v4l2_buffer.bytesused is 0 for multiplanar
buffers

Commit f61bf13b6a07 ("[media] vb2: add allow_zero_bytesused flag to the
vb2_queue struct") added a WARN_ONCE to catch usage of a deprecated API using a zero value for v4l2_buffer.bytesused.

However, the condition is checked incorrectly, as the v4L2_buffer bytesused field is supposed to be ignored for multiplanar buffers. This
results in spurious warnings when using the multiplanar API.

Fix it by checking v4l2_buffer.bytesused for uniplanar buffers and v4l2_plane.bytesused for multiplanar buffers.

Fixes f61bf13b6a07 ("[media] vb2: add allow_zero_bytesused flag to the

vb2_queue struct")

Signed-off-by: Laurent Pinchart
<[email protected]> Cc: [email protected] # for v4.0

Thanks,

Larry

Signature · 3 lines
Regards,

Laurent Pinchart
#3 lore raw
Quoted 18 lines · Laurent Pinchart

Hi Larry,

Thank you for the report.

Quoted 7 lines · On Saturday 11 July 2015 16:27:36 Larry Finger wrote:

Beginning with the commit in the subject, I get the following build error:

CC [M] drivers/media/v4l2-core/videobuf2-core.o
drivers/media/v4l2-core/videobuf2-core.c: In function ‘vb2_warn_zero_bytesused’: drivers/media/v4l2-core/videobuf2-core.c:1253:2:
error: implicit declaration of function ‘__WARN’ [-Werror=implicit-function-declaration]

Quoted 5 lines
    __WARN();
    ^

cc1: some warnings being treated as errors

My .config is attached.

Quoted 7 lines

Indeed, __WARN isn't defined when CONFIG_BUG isn't set. My bad :-/

I've send a patch to fix this (you've been CC'ed), could you please review it ?

And I've just noticed that I forgot to add your Reported-by: tag, please feel free to add it to the review.

I added my "Acked-by:" for the __WARN to WARN_ON part. In addition, the rest looks good.

I do not need a Reported-by to be added. I'm a volunteer, thus it does not matter how many times my name is mentioned. Another one will never increase my remuneration.

I have also submitted a patch to make certain that __WARN is defined even when CONFIG_DEBUG is not defined. It may not be accepted, but if it does, no one else will be caught this way.

Larry

#4 lore raw

Hi Larry,

Quoted 7 lines · On Sunday 12 July 2015 20:35:32 Larry Finger wrote:
Quoted 6 lines · Laurent Pinchart

Hi Larry,

Thank you for the report.

Quoted 1 line · On Saturday 11 July 2015 16:27:36 Larry Finger wrote:

Beginning with the commit in the subject, I get the following build

error:

Quoted 17 lines
Quoted 17 lines
Quoted 8 lines

CC [M] drivers/media/v4l2-core/videobuf2-core.o

drivers/media/v4l2-core/videobuf2-core.c: In function ‘vb2_warn_zero_bytesused’:
drivers/media/v4l2-core/videobuf2-core.c:1253:2:
error: implicit declaration of function ‘__WARN’ [-Werror=implicit-function-declaration]

Quoted 6 lines
    __WARN();
    ^

cc1: some warnings being treated as errors

My .config is attached.

Indeed, __WARN isn't defined when CONFIG_BUG isn't set. My bad :-/

Quoted 8 lines
Quoted 5 lines

I've send a patch to fix this (you've been CC'ed), could you please review it ?

And I've just noticed that I forgot to add your Reported-by: tag, please feel free to add it to the review.

I added my "Acked-by:" for the __WARN to WARN_ON part. In addition, the rest looks good.

Thank you.

Quoted 3 lines

I do not need a Reported-by to be added. I'm a volunteer, thus it does not matter how many times my name is mentioned. Another one will never increase my remuneration.

I'm afraid I wouldn't be in a position to increase your remuneration even if
you were paid to report issues :-) Still, the point of the Reported-by: tag is
recognition of contributors. This topic is currently being discussed as a
canditate for the Linux kernel summit (see
http://lists.linuxfoundation.org/pipermail/ksummit-discuss/2015-July/001318.html for instance). Feel free to chime in, we mostly have long time kernel maintainers in the e-mail thread, it would be nice to get the
point of few of volunteers as well.

Quoted 3 lines

I have also submitted a patch to make certain that __WARN is defined even when CONFIG_DEBUG is not defined. It may not be accepted, but if it does, no one else will be caught this way.

Thank you.

Signature · 3 lines
Regards,

Laurent Pinchart