test: -gt: unexpected operator
I found a bug in dash that affects checking the exit status of '[' or 'test' for failure.
After feeding an illegal number to 'test -t', 'test' will not accept any operator (or at least not -gt or -lt) for the next invocation.
Confirmed in dash 0.5.7, 0.5.8 and current git version.
$ [ -t 12323454234578326584376438 ] src/dash: 7: [: Illegal number: 12323454234578326584376438 $ [ "$?" -gt 1 ] && echo error src/dash: 8: [: -gt: unexpected operator $ [ "$?" -gt 1 ] && echo error error $ test -t 12323454234578326584376438 src/dash: 10: test: Illegal number: 12323454234578326584376438 $ test "$?" -gt 1 && echo error src/dash: 11: test: -gt: unexpected operator $ test "$?" -gt 1 && echo error error $ test -t 12323454234578326584376438 src/dash: 13: test: Illegal number: 12323454234578326584376438 $ test 2 -gt 1 src/dash: 14: test: -gt: unexpected operator $ test 2 -gt 1 $ test -t 12323454234578326584376438 src/dash: 16: test: Illegal number: 12323454234578326584376438 $ test 2 -lt 1 src/dash: 17: test: -lt: unexpected operator $ test 2 -lt 1 $
Thanks,
- Martijn
Quoted 7 lines · Martijn Dekker
I found a bug in dash that affects checking the exit status of '[' or 'test' for failure.
After feeding an illegal number to 'test -t', 'test' will not accept any operator (or at least not -gt or -lt) for the next invocation.
Confirmed in dash 0.5.7, 0.5.8 and current git version.
Thanks for the report. Does this patch help?
---8<---
Subject: builtin: Reset t_wp_op in testcmd
The global variable t_wp_op needs to be reset every time testcmd is called or it may cause incorrect parsing of the arguments.
src/bltin/test.c +2 -0
@@ -193,6 +193,8 @@ testcmd(int argc, char **argv) argv[argc] =NULL ; } + t_wp_op =NULL ; + recheck: argv++; argc--;
Signature · 3 lines
Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Herbert Xu schreef op 13-07-15 om 08:06:
Quoted 1 line
Thanks for the report. Does this patch help?
Yes, it does.
Thanks,
- M.