NFS: Remove duplicate svc_xprt_put from nfs41_callback_up

PATCH Superseded Kinglong Mee 1 participant 1 message Jul 28, 2015

Subsystems (2)

NFS client NFS server

lore

Share & tools

lore

Kinglong Mee

author

2015-07-28 11:12 UTC #0 lore raw

PATCH 1/5 NFS: Remove duplicate svc_xprt_put from nfs41_callback_up

The xprt created by svc_create_xprt have be added to serv->sv_permsocks. So putting the xprt directly is useless.
Otherwise, there is a more svc_xprt_put after the xprt be freed.

Signed-off-by Kinglong Mee <[email protected]>

---
 fs/nfs/callback.c | 4 ----
 1 file changed, 4 deletions(-)

fs/nfs/callback.c +0 -4

index 682529c..6d27d72 100644
@@ -162,10 +162,6 @@ nfs41_callback_up(struct svc_serv *serv)
 	spin_lock_init(&serv->sv_cb_lock);
 	init_waitqueue_head(&serv->sv_cb_waitq);
 	rqstp = svc_prepare_thread(serv, &serv->sv_pools[0], NUMA_NO_NODE);
-	if (IS_ERR(rqstp)) {
-		svc_xprt_put(serv->sv_bc_xprt);
-		serv->sv_bc_xprt = NULL;
-	}
 	dprintk("--> %s return %d\n", __func__, PTR_ERR_OR_ZERO(rqstp));
 	return rqstp;
 }

Signature · 1 line

2.4.3