Skip to contentSkip to conversation

Converting "board file" to device tree one device at a time?

DISCUSSION Mason 2 participants 6 messages Jul 31, 2015

lore
Share & tools
lore

Mason

author
#0 lore raw

Hello,

I'm using an ARM Cortex A9 based platform. I have a minimal 3.14 port working (UART and Ethernet, loads a root file system over NFS) using a board file.

I'm trying to convert the port to device tree, so that I can (try to) push it upstream.

As I can't wrap my head around the concept, I'm trying to do the conversion "one device at a time", starting with just the UART, then Ethernet, then the clock tree, and that's basically all I need to boot the board.

I started by enabling

CONFIG_ARM_APPENDED_DTB=y CONFIG_ARM_ATAG_DTB_COMPAT=y CONFIG_ARM_ATAG_DTB_COMPAT_CMDLINE_FROM_BOOTLOADER=y CONFIG_SERIAL_OF_PLATFORM=y

and wrote this dts:

/dts-v1/;

/ {
	compatible = "sigma,tango4-soc";

	#address-cells = <1>;
	#size-cells = <1>;

	soc {
		compatible = "simple-bus";
		#address-cells = <1>;
		#size-cells = <1>;
		ranges;

		uart0: serial at 10700 {
			compatible = "ns16550a";
			reg = <0x10700 0x100>;
			interrupts = <1>;
			clock-frequency = <7372800>;
			reg-shift = <2>;
			no-loopback-test;

			#address-cells = <1>;
			#size-cells = <1>;
		};
	};
};

and added "sigma,tango4-soc" to my struct machine_desc .dt_compat

Then I generated a kernel with appended DT using:

$ make dtbs
$ make -j2 zImage && cat arch/arm/boot/zImage arch/arm/boot/dts/tango.dtb >XXX
$ mv XXX arch/arm/boot/zImage && make uImage

Then I set a breakpoint in of_platform_serial_probe, hoping to witness the miracle... and nothing. Looks like device is never registered :-(

Can anyone point me where to look?
What did I do wrong?

Where does the kernel parse the appended DTB?
Is it setup_machine_fdt?

When/Where is the UART description in the device tree supposed to be used to register the device?

Any help greatly appreciated!

Regards.

author
#1 lore raw
Quoted 3 lines · Mason

Then I set a breakpoint in of_platform_serial_probe, hoping to witness the miracle... and nothing. Looks like device is never registered :-(

IIUC, the kernel is supposed to parse my "uart0" node, and register the device. Then the platform framework should see that the node's "compatible" property is equal to one advertized by the of_platform_serial_driver, and the kernel should #!@& call of_platform_serial_probe? Right?!

I just can't believe how much time I've been pulling my hair over this trivial issue...

Regards.

#2 lore raw
Quoted 11 lines · Mason
Quoted 3 lines · Mason

Then I set a breakpoint in of_platform_serial_probe, hoping to witness the miracle... and nothing. Looks like device is never registered :-(

IIUC, the kernel is supposed to parse my "uart0" node, and register the device. Then the platform framework should see that the node's "compatible" property is equal to one advertized by the of_platform_serial_driver, and the kernel should #!@& call of_platform_serial_probe? Right?!

No, it doesn't work like that. The kernel creates platform devices from the nodes described in the DT file, which are then used to bind to the drivers in a very similar way to non-DT, except that if there's an dev->of_node pointer present, the compatible property is used. If there are no devices being created from DT, drivers won't have anything to bind to.

Quoted 2 lines

I just can't believe how much time I've been pulling my hair over this trivial issue...

My /guess/ is that you have an .init_machine callback in place, but that is not calling of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL); which means none of the DT-described devices are being created.

Signature · 2 lines
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
author
#3 lore raw
Quoted 20 lines · Russell King - ARM Linux
Quoted 11 lines · Mason
Quoted 3 lines · Mason

Then I set a breakpoint in of_platform_serial_probe, hoping to witness the miracle... and nothing. Looks like device is never registered :-(

IIUC, the kernel is supposed to parse my "uart0" node, and register the device. Then the platform framework should see that the node's "compatible" property is equal to one advertized by the of_platform_serial_driver, and the kernel should #!@& call of_platform_serial_probe? Right?!

No, it doesn't work like that. The kernel creates platform devices from the nodes described in the DT file, which are then used to bind to the drivers in a very similar way to non-DT, except that if there's an dev->of_node pointer present, the compatible property is used. If there are no devices being created from DT, drivers won't have anything to bind to.

Quoted 7 lines
Quoted 2 lines

I just can't believe how much time I've been pulling my hair over this trivial issue...

My /guess/ is that you have an .init_machine callback in place, but that is not calling of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL); which means none of the DT-described devices are being created.

You are my savior.

Yes, I've read 5 bazillion OF/FDT tutorials/overviews, and I managed to miss of_platform_populate. You have just saved this desk from one more week of head-banging. Thanks again!

Regards.

author
#4 lore raw
In reply to Russell King - ARM Linux
Quoted 4 lines · Russell King - ARM Linux

My /guess/ is that you have an .init_machine callback in place, but that is not calling of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL); which means none of the DT-described devices are being created.

You guessed right. Thanks again!

One more question, if I may.

I deleted the .init_machine callback, but the board init function was still being called!

MACHINE_START(TANGOX_87XX, "TANGOX_87XX")
...
//.init_machine = tangox_87xx_board_init,
MACHINE_END

I suspected it might be called directly from elsewhere, and launched grep:

  arch_initcall(tangox_init_devices);

I suppose the arch_initcall macro registers the function to be called at some point during init?

Then this means that, before I commented the .init_machine callback, the function was being called twice?

Once through .init_machine and once through arch_initcall?

Regards.

#5 lore raw
Quoted 19 lines · Mason
Quoted 4 lines · Russell King - ARM Linux

My /guess/ is that you have an .init_machine callback in place, but that is not calling of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL); which means none of the DT-described devices are being created.

You guessed right. Thanks again!

One more question, if I may.

I deleted the .init_machine callback, but the board init function was still being called!

MACHINE_START(TANGOX_87XX, "TANGOX_87XX")
...
//.init_machine = tangox_87xx_board_init,
MACHINE_END

Quoted 4 lines

I suspected it might be called directly from elsewhere, and launched grep:

  arch_initcall(tangox_init_devices);

Looks like different function names to me. Not being able to see the code you're modifying means I can't comment.

Signature · 2 lines
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.