mmc/sdhci-acpi: enable sdhci-acpi device to suspend/resume asynchronously

PATCH In review Fu, Zhonghui 2 participants 5 messages Aug 3, 2015 – Sep 21, 2015

Subsystems (2)

MMC, SD and SDIO Secure digital host controller interface (SDHCI) driver

lore

Share & tools

lore

Fu, Zhonghui

author

2015-08-17 03:38 UTC #1 lore raw

Hi,

Any comments are welcome.

Thanks,
Zhonghui

Quoted 23 lines · Zhonghui

Enable sdhci-acpi device to suspend/resume asynchronously. This can improve system suspend/resume speed.
Signed-off-by Zhonghui Fu <[email protected]>
---
 drivers/mmc/host/sdhci-acpi.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
drivers/mmc/host/sdhci-acpi.c +2 -1
index 22d929f..67e6263 100644
@@ -379,6 +379,8 @@ static int sdhci_acpi_probe(struct platform_device *pdev)
 		pm_runtime_enable(dev);
 	}
 
+	device_enable_async_suspend(dev);
+
 	return 0;
 
 err_free:
-- 1.7.1

Adrian Hunter

maintainer

2015-08-17 06:54 UTC #2 lore raw

Quoted 4 lines · Zhonghui

Hi,
Any comments are welcome.

Same comments as here:

	http://marc.info/?l=linux-kernel&m=143979428424353&w=2

Quoted 32 lines

Thanks,
Zhonghui
Quoted 23 lines · Zhonghui
Enable sdhci-acpi device to suspend/resume asynchronously. This can improve system suspend/resume speed.
Signed-off-by Zhonghui Fu <[email protected]>
---
 drivers/mmc/host/sdhci-acpi.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
drivers/mmc/host/sdhci-acpi.c +2 -1
index 22d929f..67e6263 100644
@@ -379,6 +379,8 @@ static int sdhci_acpi_probe(struct platform_device *pdev)
 		pm_runtime_enable(dev);
 	}
 
+	device_enable_async_suspend(dev);
+
 	return 0;
 
 err_free:
-- 1.7.1

Fu, Zhonghui

author

2015-08-24 15:14 UTC #3 lore raw

Quoted 7 lines · Adrian Hunter

Quoted 3 lines · Zhonghui
Hi,
Any comments are welcome.
Same comments as here:
	http://marc.info/?l=linux-kernel&m=143979428424353&w=2

Now, PM core support asynchronous device suspend/resume mode. If one device has been set to support asynchronous PM mode, it's suspend/resume operation can be performed in a separate kernel thread and take advantage of multicore feature to improve overall system suspend/resume speed. The worst case is that all device suspend/resume threads will be scheduled to the same CPU, it hardly occur.

PM core ensure all the suspend/resume dependency related to one device. Actually, async suspend/resume mode is one feature of PM core, every device subsystem may use it or not use it. Once one device subsystem choose to use this feature, its safety is up to PM core as long as device subsystem has initialized fully this device.

Thanks,
Zhonghui

Quoted 36 lines

Quoted 22 lines
Thanks,
Zhonghui
Quoted 16 lines · Zhonghui
Enable sdhci-acpi device to suspend/resume asynchronously. This can improve system suspend/resume speed.
Signed-off-by Zhonghui Fu <[email protected]>
---
 drivers/mmc/host/sdhci-acpi.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
drivers/mmc/host/sdhci-acpi.c +0 -0
index 22d929f..67e6263 100644
@@ -379,6 +379,8 @@ static int sdhci_acpi_probe(struct platform_device *pdev)
 		pm_runtime_enable(dev);
 	}
 
Quoted 9 lines
drivers/mmc/host/sdhci-acpi.c static int sdhci_acpi_probe(struct platform_device *pdev)
Quoted 7 lines
drivers/mmc/host/sdhci-acpi.c +2 -1
+	device_enable_async_suspend(dev);
+
 	return 0;
 
 err_free:
-- 1.7.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Fu, Zhonghui

author

2015-09-21 06:54 UTC #4 lore raw

Quoted 5 lines · Zhonghui

Quoted 3 lines · Adrian Hunter
Quoted 2 lines · Zhonghui
Hi,

Quoted 7 lines

Quoted 4 lines
Quoted 1 line
Any comments are welcome.
Same comments as here:
	http://marc.info/?l=linux-kernel&m=143979428424353&w=2
Now, PM core support asynchronous device suspend/resume mode. If one device has been set to support asynchronous PM mode, it's suspend/resume operation can be performed in a separate kernel thread and take advantage of multicore feature to improve overall system suspend/resume speed. The worst case is that all device suspend/resume threads will be scheduled to the same CPU, it hardly occur.
PM core ensure all the suspend/resume dependency related to one device. Actually, async suspend/resume mode is one feature of PM core, every device subsystem may use it or not use it. Once one device subsystem choose to use this feature, its safety is up to PM core as long as device subsystem has initialized fully this device.

The original suspend time is 1645ms and resume time is 940ms on ASUS T100TA machine. After enabling "wiphy device", "SDIO device", "mmc host" and "sdhci-acpi device" to suspend/resume asynchronously, the suspend time is 1096ms and resume time is 908ms. The test environment is listed as follows:

OS: Ubuntu 14.04
Kernel: mainline v4.1
Machine: ASUS T100TA(Baytrail-T platform)
Tool: analyze_suspend
“analyze_suspend.py –f –m freeze” to suspend system Press power button to resume system

I have resent this patch with updated commit message - "[PATCH v2] mmc/sdhci-acpi: enable sdhci-acpi device to suspend/resume asynchronously".

Thanks,
Zhonghui

Quoted 39 lines

Thanks,
Zhonghui
Quoted 33 lines
Quoted 20 lines
Thanks,
Zhonghui
Quoted 16 lines · Zhonghui
Enable sdhci-acpi device to suspend/resume asynchronously. This can improve system suspend/resume speed.
Signed-off-by Zhonghui Fu <[email protected]>
---
 drivers/mmc/host/sdhci-acpi.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
drivers/mmc/host/sdhci-acpi.c +0 -0
index 22d929f..67e6263 100644
@@ -379,6 +379,8 @@ static int sdhci_acpi_probe(struct platform_device *pdev)
 		pm_runtime_enable(dev);
 	}
 
Quoted 8 lines
drivers/mmc/host/sdhci-acpi.c static int sdhci_acpi_probe(struct platform_device *pdev)
Quoted 7 lines
drivers/mmc/host/sdhci-acpi.c +2 -1
+	device_enable_async_suspend(dev);
+
 	return 0;
 
 err_free:
-- 1.7.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/