xfs_fsr: Fix parentheses around truth value
PATCH 1/1 xfs_fsr: Fix parentheses around truth value
Someone in the distant past must have responded to gcc's warning about parentheses around assignment used as a truth value by changing:
while (ret = func() == 0) to: while ((ret = func() == 0))
While this shuts up gcc, it doesn't yield the proper result. If func () returns 0, func == 0 is true, and ret is assigned a value of 1.
This does keep the while loop going, but it's a very strange way to go about it, and may someday yield confusing results.
Fix this as:
while ((ret = func()) == 0)
so that ret gets the function return value as expected.
---
fsr/xfs_fsr.c +1 -1
@@ -716,7 +716,7 @@ fsrfs(char *mntdir, xfs_ino_t startino, int targetrange)tmp_init (mntdir);while ((ret =xfs_bulkstat (fsfd, - &lastino,GRABSZ , &buf[0 ], &buflenout) ==0 )) { + &lastino,GRABSZ , &buf[0 ], &buflenout)) ==0 ) {xfs_bstat_t *p;xfs_bstat_t *endp;
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Looks good,
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs