Skip to contentSkip to conversation

unmet direct dependencies in -next

DISCUSSION Richard Weinberger 5 participants 8 messages Aug 9, 2015 – Jan 2, 2016 2 messages not in the archive

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

Hi!

-next faces some build issues on UML because of unmet direct dependencies. Mostly due to HAS_IOMEM and I2C.

warning: (MEDIA_SUBDRV_AUTOSELECT && VIDEO_CX231XX && INV_MPU6050_IIO) selects I2C_MUX which has unmet direct dependencies (I2C && HAS_IOMEM)
warning: (ST_IRQCHIP && HIP04_ETH && STMMAC_PLATFORM && DWMAC_IPQ806X && DWMAC_LPC18XX && DWMAC_ROCKCHIP && DWMAC_SOCFPGA && DWMAC_STI && TI_CPSW && PINCTRL_ROCKCHIP && PINCTRL_DOVE && POWER_RESET_KEYSTONE && POWER_RESET_SYSCON && POWER_RESET_SYSCON_POWEROFF && S3C2410_WATCHDOG && VIDEO_OMAP3 && VIDEO_S5P_FIMC && RTC_DRV_AT91SAM9 && VIDEO_OMAP4 && HWSPINLOCK_QCOM && ATMEL_ST && QCOM_GSBI) selects MFD_SYSCON which has unmet direct dependencies (HAS_IOMEM)
warning: (MEDIA_SUBDRV_AUTOSELECT && VIDEO_CX231XX && INV_MPU6050_IIO) selects I2C_MUX which has unmet direct dependencies (I2C && HAS_IOMEM)
warning: (ST_IRQCHIP && HIP04_ETH && STMMAC_PLATFORM && DWMAC_IPQ806X && DWMAC_LPC18XX && DWMAC_ROCKCHIP && DWMAC_SOCFPGA && DWMAC_STI && TI_CPSW && PINCTRL_ROCKCHIP && PINCTRL_DOVE && POWER_RESET_KEYSTONE && POWER_RESET_SYSCON && POWER_RESET_SYSCON_POWEROFF && S3C2410_WATCHDOG && VIDEO_OMAP3 && VIDEO_S5P_FIMC && RTC_DRV_AT91SAM9 && VIDEO_OMAP4 && HWSPINLOCK_QCOM && ATMEL_ST && QCOM_GSBI) selects MFD_SYSCON which has unmet direct dependencies (HAS_IOMEM)

For example MFD_SYSCON cannot build on UML as it depends on HAS_IOMEM.
While the symbol MFD_SYSCON has correct dependencies some users of MFD_SYSCON
just issue a "select MFD_SYSCON" and bypass the HAS_IOMEM dependency and causing the build to fail.

This brings me to a question on kconfig itself, wouldn't it be better to just disable a symbol if it has unmet direct dependencies?

Thanks,
//richard

#2 lore raw
In reply to a message not in the archive
Quoted 14 lines · Richard Weinberger

Hi!

-next faces some build issues on UML because of unmet direct dependencies. Mostly due to HAS_IOMEM and I2C.

warning: (MEDIA_SUBDRV_AUTOSELECT && VIDEO_CX231XX && INV_MPU6050_IIO) selects I2C_MUX which has unmet direct dependencies (I2C && HAS_IOMEM)
warning: (ST_IRQCHIP && HIP04_ETH && STMMAC_PLATFORM && DWMAC_IPQ806X && DWMAC_LPC18XX && DWMAC_ROCKCHIP && DWMAC_SOCFPGA && DWMAC_STI && TI_CPSW && PINCTRL_ROCKCHIP && PINCTRL_DOVE && POWER_RESET_KEYSTONE && POWER_RESET_SYSCON && POWER_RESET_SYSCON_POWEROFF && S3C2410_WATCHDOG && VIDEO_OMAP3 && VIDEO_S5P_FIMC && RTC_DRV_AT91SAM9 && VIDEO_OMAP4 && HWSPINLOCK_QCOM && ATMEL_ST && QCOM_GSBI) selects MFD_SYSCON which has unmet direct dependencies (HAS_IOMEM)
warning: (MEDIA_SUBDRV_AUTOSELECT && VIDEO_CX231XX && INV_MPU6050_IIO) selects I2C_MUX which has unmet direct dependencies (I2C && HAS_IOMEM)
warning: (ST_IRQCHIP && HIP04_ETH && STMMAC_PLATFORM && DWMAC_IPQ806X && DWMAC_LPC18XX && DWMAC_ROCKCHIP && DWMAC_SOCFPGA && DWMAC_STI && TI_CPSW && PINCTRL_ROCKCHIP && PINCTRL_DOVE && POWER_RESET_KEYSTONE && POWER_RESET_SYSCON && POWER_RESET_SYSCON_POWEROFF && S3C2410_WATCHDOG && VIDEO_OMAP3 && VIDEO_S5P_FIMC && RTC_DRV_AT91SAM9 && VIDEO_OMAP4 && HWSPINLOCK_QCOM && ATMEL_ST && QCOM_GSBI) selects MFD_SYSCON which has unmet direct dependencies (HAS_IOMEM)

Quoted 6 lines

For example MFD_SYSCON cannot build on UML as it depends on HAS_IOMEM.
While the symbol MFD_SYSCON has correct dependencies some users of MFD_SYSCON
just issue a "select MFD_SYSCON" and bypass the HAS_IOMEM dependency and causing the build to fail.

This brings me to a question on kconfig itself, wouldn't it be better to just disable a symbol if it has unmet direct dependencies?

If this is a question about "kconfig itself", you should probably have included the correct ML and Maintainer:

KCONFIG

M:      Michal Marek <[email protected]>
L:      [email protected]
S:      Odd Fixes
F:      Documentation/kbuild/kconfig-language.txt
F:      scripts/kconfig/

There are also quite a few interested parties on LKML who might be inclined to submit a fix for you.

Signature · 4 lines
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
#3 lore raw

Am 10.08.2015 um 11:10 schrieb Lee Jones:

Quoted 26 lines · Richard Weinberger
Quoted 15 lines

Hi!

-next faces some build issues on UML because of unmet direct dependencies. Mostly due to HAS_IOMEM and I2C.

warning: (MEDIA_SUBDRV_AUTOSELECT && VIDEO_CX231XX && INV_MPU6050_IIO) selects I2C_MUX which has unmet direct dependencies (I2C && HAS_IOMEM)
warning: (ST_IRQCHIP && HIP04_ETH && STMMAC_PLATFORM && DWMAC_IPQ806X && DWMAC_LPC18XX && DWMAC_ROCKCHIP && DWMAC_SOCFPGA && DWMAC_STI && TI_CPSW && PINCTRL_ROCKCHIP && PINCTRL_DOVE && POWER_RESET_KEYSTONE && POWER_RESET_SYSCON && POWER_RESET_SYSCON_POWEROFF && S3C2410_WATCHDOG && VIDEO_OMAP3 && VIDEO_S5P_FIMC && RTC_DRV_AT91SAM9 && VIDEO_OMAP4 && HWSPINLOCK_QCOM && ATMEL_ST && QCOM_GSBI) selects MFD_SYSCON which has unmet direct dependencies (HAS_IOMEM)
warning: (MEDIA_SUBDRV_AUTOSELECT && VIDEO_CX231XX && INV_MPU6050_IIO) selects I2C_MUX which has unmet direct dependencies (I2C && HAS_IOMEM)
warning: (ST_IRQCHIP && HIP04_ETH && STMMAC_PLATFORM && DWMAC_IPQ806X && DWMAC_LPC18XX && DWMAC_ROCKCHIP && DWMAC_SOCFPGA && DWMAC_STI && TI_CPSW && PINCTRL_ROCKCHIP && PINCTRL_DOVE && POWER_RESET_KEYSTONE && POWER_RESET_SYSCON && POWER_RESET_SYSCON_POWEROFF && S3C2410_WATCHDOG && VIDEO_OMAP3 && VIDEO_S5P_FIMC && RTC_DRV_AT91SAM9 && VIDEO_OMAP4 && HWSPINLOCK_QCOM && ATMEL_ST && QCOM_GSBI) selects MFD_SYSCON which has unmet direct dependencies (HAS_IOMEM)

Quoted 6 lines

For example MFD_SYSCON cannot build on UML as it depends on HAS_IOMEM.
While the symbol MFD_SYSCON has correct dependencies some users of MFD_SYSCON
just issue a "select MFD_SYSCON" and bypass the HAS_IOMEM dependency and causing the build to fail.

This brings me to a question on kconfig itself, wouldn't it be better to just disable a symbol if it has unmet direct dependencies?

If this is a question about "kconfig itself", you should probably have included the correct ML and Maintainer:

Quoted 6 lines

KCONFIG

M:      Michal Marek <[email protected]>
L:      [email protected]
S:      Odd Fixes
F:      Documentation/kbuild/kconfig-language.txt
F:      scripts/kconfig/

Isn't this kbuild related? I've added kbuild folks... But adding Michal now too...

Thanks,
//richard

#5 lore raw
In reply to a message not in the archive
Quoted 23 lines · Richard Weinberger

Am 10.08.2015 um 11:10 schrieb Lee Jones:

Quoted 22 lines · Richard Weinberger
Quoted 21 lines

Hi!

-next faces some build issues on UML because of unmet direct dependencies. Mostly due to HAS_IOMEM and I2C.

warning: (MEDIA_SUBDRV_AUTOSELECT && VIDEO_CX231XX && INV_MPU6050_IIO) selects I2C_MUX which has unmet direct dependencies (I2C && HAS_IOMEM)
warning: (ST_IRQCHIP && HIP04_ETH && STMMAC_PLATFORM && DWMAC_IPQ806X && DWMAC_LPC18XX && DWMAC_ROCKCHIP && DWMAC_SOCFPGA && DWMAC_STI && TI_CPSW && PINCTRL_ROCKCHIP && PINCTRL_DOVE && POWER_RESET_KEYSTONE && POWER_RESET_SYSCON && POWER_RESET_SYSCON_POWEROFF && S3C2410_WATCHDOG && VIDEO_OMAP3 && VIDEO_S5P_FIMC && RTC_DRV_AT91SAM9 && VIDEO_OMAP4 && HWSPINLOCK_QCOM && ATMEL_ST && QCOM_GSBI) selects MFD_SYSCON which has unmet direct dependencies (HAS_IOMEM)
warning: (MEDIA_SUBDRV_AUTOSELECT && VIDEO_CX231XX && INV_MPU6050_IIO) selects I2C_MUX which has unmet direct dependencies (I2C && HAS_IOMEM)
warning: (ST_IRQCHIP && HIP04_ETH && STMMAC_PLATFORM && DWMAC_IPQ806X && DWMAC_LPC18XX && DWMAC_ROCKCHIP && DWMAC_SOCFPGA && DWMAC_STI && TI_CPSW && PINCTRL_ROCKCHIP && PINCTRL_DOVE && POWER_RESET_KEYSTONE && POWER_RESET_SYSCON && POWER_RESET_SYSCON_POWEROFF && S3C2410_WATCHDOG && VIDEO_OMAP3 && VIDEO_S5P_FIMC && RTC_DRV_AT91SAM9 && VIDEO_OMAP4 && HWSPINLOCK_QCOM && ATMEL_ST && QCOM_GSBI) selects MFD_SYSCON which has unmet direct dependencies (HAS_IOMEM)

For example MFD_SYSCON cannot build on UML as it depends on HAS_IOMEM.
While the symbol MFD_SYSCON has correct dependencies some users of MFD_SYSCON
just issue a "select MFD_SYSCON" and bypass the HAS_IOMEM dependency and causing the build to fail.

This brings me to a question on kconfig itself, wouldn't it be better to just disable a symbol if it has unmet direct dependencies?

The result of the given .config does not matter as much. The point of the warnings is that there are missing select statements in the Kconfig files.

Michal

#6 lore raw

Am 10.08.2015 um 13:12 schrieb Michal Marek:

Quoted 22 lines · Richard Weinberger
Quoted 21 lines

Am 10.08.2015 um 11:10 schrieb Lee Jones:

Quoted 20 lines · Richard Weinberger
Quoted 19 lines

Hi!

-next faces some build issues on UML because of unmet direct dependencies. Mostly due to HAS_IOMEM and I2C.

warning: (MEDIA_SUBDRV_AUTOSELECT && VIDEO_CX231XX && INV_MPU6050_IIO) selects I2C_MUX which has unmet direct dependencies (I2C && HAS_IOMEM)
warning: (ST_IRQCHIP && HIP04_ETH && STMMAC_PLATFORM && DWMAC_IPQ806X && DWMAC_LPC18XX && DWMAC_ROCKCHIP && DWMAC_SOCFPGA && DWMAC_STI && TI_CPSW && PINCTRL_ROCKCHIP && PINCTRL_DOVE && POWER_RESET_KEYSTONE && POWER_RESET_SYSCON && POWER_RESET_SYSCON_POWEROFF && S3C2410_WATCHDOG && VIDEO_OMAP3 && VIDEO_S5P_FIMC && RTC_DRV_AT91SAM9 && VIDEO_OMAP4 && HWSPINLOCK_QCOM && ATMEL_ST && QCOM_GSBI) selects MFD_SYSCON which has unmet direct dependencies (HAS_IOMEM)
warning: (MEDIA_SUBDRV_AUTOSELECT && VIDEO_CX231XX && INV_MPU6050_IIO) selects I2C_MUX which has unmet direct dependencies (I2C && HAS_IOMEM)
warning: (ST_IRQCHIP && HIP04_ETH && STMMAC_PLATFORM && DWMAC_IPQ806X && DWMAC_LPC18XX && DWMAC_ROCKCHIP && DWMAC_SOCFPGA && DWMAC_STI && TI_CPSW && PINCTRL_ROCKCHIP && PINCTRL_DOVE && POWER_RESET_KEYSTONE && POWER_RESET_SYSCON && POWER_RESET_SYSCON_POWEROFF && S3C2410_WATCHDOG && VIDEO_OMAP3 && VIDEO_S5P_FIMC && RTC_DRV_AT91SAM9 && VIDEO_OMAP4 && HWSPINLOCK_QCOM && ATMEL_ST && QCOM_GSBI) selects MFD_SYSCON which has unmet direct dependencies (HAS_IOMEM)

For example MFD_SYSCON cannot build on UML as it depends on HAS_IOMEM.
While the symbol MFD_SYSCON has correct dependencies some users of MFD_SYSCON
just issue a "select MFD_SYSCON" and bypass the HAS_IOMEM dependency and causing the build to fail.

Quoted 6 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

This brings me to a question on kconfig itself, wouldn't it be better to just disable a symbol if it has unmet direct dependencies?

The result of the given .config does not matter as much. The point of the warnings is that there are missing select statements in the Kconfig files.

IMHO the situation could be improved.
What about of failing hard "Your Kconfig is broken" or as I wrote disabling affected symbols?

The current warning is something between.
Kbuild detects that something is broken but produces a .config file.

Thanks,
//richard

#7 lore raw
In reply to Michal Marek
Quoted 4 lines

The result of the given .config does not matter as much. The point of the warnings is that there are missing select statements in the Kconfig files.

For the I2C part, I think they should rather depend on I2C_MUX. Selecting I2C should be rare, like when you really need that PMIC to boot.

#8 lore raw
Quoted 8 lines · Wolfram Sang
Quoted 4 lines

The result of the given .config does not matter as much. The point of the warnings is that there are missing select statements in the Kconfig files.

For the I2C part, I think they should rather depend on I2C_MUX. Selecting I2C should be rare, like when you really need that PMIC to boot.

Right, that's another way to fix it.

Michal

#9 lore raw
In reply to Michal Marek

Am 10.08.2015 um 13:12 schrieb Michal Marek:

Quoted 18 lines · Richard Weinberger
Quoted 17 lines

Am 10.08.2015 um 11:10 schrieb Lee Jones:

Quoted 16 lines · Richard Weinberger
Quoted 15 lines

Hi!

-next faces some build issues on UML because of unmet direct dependencies. Mostly due to HAS_IOMEM and I2C.

warning: (MEDIA_SUBDRV_AUTOSELECT && VIDEO_CX231XX && INV_MPU6050_IIO) selects I2C_MUX which has unmet direct dependencies (I2C && HAS_IOMEM)
warning: (ST_IRQCHIP && HIP04_ETH && STMMAC_PLATFORM && DWMAC_IPQ806X && DWMAC_LPC18XX && DWMAC_ROCKCHIP && DWMAC_SOCFPGA && DWMAC_STI && TI_CPSW && PINCTRL_ROCKCHIP && PINCTRL_DOVE && POWER_RESET_KEYSTONE && POWER_RESET_SYSCON && POWER_RESET_SYSCON_POWEROFF && S3C2410_WATCHDOG && VIDEO_OMAP3 && VIDEO_S5P_FIMC && RTC_DRV_AT91SAM9 && VIDEO_OMAP4 && HWSPINLOCK_QCOM && ATMEL_ST && QCOM_GSBI) selects MFD_SYSCON which has unmet direct dependencies (HAS_IOMEM)
warning: (MEDIA_SUBDRV_AUTOSELECT && VIDEO_CX231XX && INV_MPU6050_IIO) selects I2C_MUX which has unmet direct dependencies (I2C && HAS_IOMEM)
warning: (ST_IRQCHIP && HIP04_ETH && STMMAC_PLATFORM && DWMAC_IPQ806X && DWMAC_LPC18XX && DWMAC_ROCKCHIP && DWMAC_SOCFPGA && DWMAC_STI && TI_CPSW && PINCTRL_ROCKCHIP && PINCTRL_DOVE && POWER_RESET_KEYSTONE && POWER_RESET_SYSCON && POWER_RESET_SYSCON_POWEROFF && S3C2410_WATCHDOG && VIDEO_OMAP3 && VIDEO_S5P_FIMC && RTC_DRV_AT91SAM9 && VIDEO_OMAP4 && HWSPINLOCK_QCOM && ATMEL_ST && QCOM_GSBI) selects MFD_SYSCON which has unmet direct dependencies (HAS_IOMEM)

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

For example MFD_SYSCON cannot build on UML as it depends on HAS_IOMEM.
While the symbol MFD_SYSCON has correct dependencies some users of MFD_SYSCON
just issue a "select MFD_SYSCON" and bypass the HAS_IOMEM dependency and causing the build to fail.

This brings me to a question on kconfig itself, wouldn't it be better to just disable a symbol if it has unmet direct dependencies?

FYI, -next is still facing:
warning: (ST_IRQCHIP && HIP04_ETH && STMMAC_PLATFORM && DWMAC_IPQ806X && DWMAC_LPC18XX && DWMAC_ROCKCHIP && DWMAC_SOCFPGA && DWMAC_STI && TI_CPSW && PINCTRL_ROCKCHIP && PINCTRL_DOVE && POWER_RESET_KEYSTONE && POWER_RESET_SYSCON && POWER_RESET_SYSCON_POWEROFF && S3C2410_WATCHDOG && VIDEO_OMAP3 && VIDEO_S5P_FIMC && USB_XHCI_MTK && RTC_DRV_AT91SAM9 && LPC18XX_DMAMUX && VIDEO_OMAP4 && HWSPINLOCK_QCOM && ATMEL_ST && QCOM_GSBI && PHY_HI6220_USB) selects MFD_SYSCON which has unmet direct dependencies (HAS_IOMEM)
warning: (MEDIA_SUBDRV_AUTOSELECT && VIDEO_CX231XX && INV_MPU6050_IIO) selects I2C_MUX which has unmet direct dependencies (I2C && HAS_IOMEM)

Thanks,
//richard