Problem with error paths in various functions calling kvm_io_bus_unregister_dev
Paolo Bonzini
maintainerQuoted 8 lines · nick
Our we to just assume
that calls tokvm_io_bug_unregister_devalways succeed as I disagree due to it allocating memory in kernel space that can easily fail. In additon I was wondering how the maintainers would like me to handle these calls as it's difficult due to it already being in error paths. Further more below is a link to the files and how the calls tokvm_io_bus_register_devare executed in the respective error paths.
http://lxr.free-electrons.com/ident?i=kvm_io_bus_unregister_dev
You're right; the fix is not simple. The best way is to introduce a new API to register or unregister multiple devices atomically. This gets rid of calls in the error paths.
Paolo