Skip to contentSkip to conversation

Suggestion: sanity check for git branch value

DISCUSSION Carlos Rafael Giani 2 participants 2 messages Aug 20, 2015

lore
Share & tools
lore
#0 lore raw

Hello,

several recipes have SRC_URI lines like: "git://server.name/repository;branch=${SRCBRANCH}". If for some reason SRCBRANCH is empty, this essentially evaluates to "branch=". I think a simple sanity check that outputs an error if the branch value is empty would be useful, since otherwise, this leads to a very confusing error later (git fetcher tries to use a command line like: --set-upstream origin/ , which causes git to complain that "origin/" is not valid).

thoughts?

#1 lore raw

Em 20/08/2015 10:43, "Carlos Rafael Giani" <[email protected]> escreveu:

Quoted 1 line

several recipes have SRC_URI lines like: "git://

server.name/repository;branch=${SRCBRANCH}". If for some reason SRCBRANCH is empty, this essentially evaluates to "branch=". I think a simple sanity check that outputs an error if the branch value is empty would be useful, since otherwise, this leads to a very confusing error later (git fetcher tries to use a command line like: --set-upstream origin/ , which causes git to complain that "origin/" is not valid).

Quoted 2 lines

thoughts?

I fully agree. It seems to need to be done in bitbake code.