Skip to contentSkip to conversation

Bug in package tftp

Buildroot universe II 3 participants 3 messages Aug 21, 2015 – Aug 24, 2015

lore
Share & tools
lore
#0 lore raw

Dear all,
when adding the tftp server to my target system image I found out that the tftp server is not started by the corresponding init script. Reason for that is a typo in the init script. The tftp binary is installed with the filename "tftpd" but the init script tries to call "in.tftpd". Just fixing the name in the script solves the problem. Please find below the patch for correcting the bug.

Regards,
Andreas

tftpd/S80tftpd-hpa 2015-08-07 14:44:19.394469103 +0200 renamed from tftpd/S80tftpd-hpa 2015-08-07 11:38:37.572148556 +0200 +1 -1
diff -Naur a/tftpd/S80tftpd-hpa b/tftpd/S80tftpd-hpa
@@ -6,7 +6,7 @@
 
  PATH=/usr/local/sbin:/usr/local/bin:/sbin:/bin:/usr/sbin:/usr/bin
  DESC="HPA's tftpd"
-NAME=in.tftpd
+NAME=tftpd
  DAEMON=/usr/sbin/$NAME
  PIDFILE=/var/run/$NAME.pid
  SCRIPTNAME=/etc/init.d/S80tftpd-hpa

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20150821/e21e33fe/attachment.html>

#1 lore raw

Dear Andreas,

Quoted 1 line · universe II

diff -Naur a/tftpd/S80tftpd-hpa b/tftpd/S80tftpd-hpa

that's not correct. You made the patch manually using "diff" from the package directory, so the paths are not relative to $(TOPDIR). Anyway, why you didn't make the patch using git?
You make the changes to the package/tftpd/S80tftpd-hpa file. Add that file. Commit. And then use "git send-email --to=buildroot at buildroot.org -1" (-1 to send only one patch starting from the HEAD).

Regards,

Vincent.

#2 lore raw
In reply to universe II
Quoted 10 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"universe" == universe <[email protected]> writes:

Dear all,
when adding the tftp server to my target system image I found out that the tftp server is not started by the corresponding init script. Reason for that is a typo in the init script. The tftp binary is installed with the filename "tftpd" but the init script tries to call "in.tftpd". Just fixing the name in the script solves the problem. Please find below the patch for correcting the bug.

Quoted 2 lines

Regards,
Andreas

Fixed, thanks. In the future, please provide git formatted patches and use your real name in From: and your Signed-off-by lines.

Signature · 1 line
Bye, Peter Korsgaard