Skip to contentSkip to conversation

memory-hotplug: fix comment in zone_spanned_pages_in_node() and zone_spanned_pages_in_node()

PATCH In review Xishi Qiu 2 participants 2 messages Aug 25, 2015

Subsystems (2)
Memory management Page allocator
lore
Share & tools
lore

Xishi Qiu

author
#0 lore raw

PATCH 1/1 memory-hotplug: fix comment in zone_spanned_pages_in_node() and zone_spanned_pages_in_node()

When hotadd a node from add_memory(), we will add memblock first, so the node is not empty. But when from cpu_up(), the node should be empty.

Signed-off-by Xishi Qiu <[email protected]>
---
 mm/page_alloc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
mm/page_alloc.c +2 -2
index 2ec3ca3..d370445 100644
@@ -5051,7 +5051,7 @@ static unsigned long __meminit zone_spanned_pages_in_node(int nid,
 {
 	unsigned long zone_start_pfn, zone_end_pfn;
 
-	/* When hotadd a new node, the node should be empty */
+	/* When hotadd a new node from cpu_up(), the node should be empty */
 	if (!node_start_pfn && !node_end_pfn)
 		return 0;
 

@@ -5118,7 +5118,7 @@ static unsigned long __meminit zone_absent_pages_in_node(int nid,
 	unsigned long zone_high = arch_zone_highest_possible_pfn[zone_type];
 	unsigned long zone_start_pfn, zone_end_pfn;
 
-	/* When hotadd a new node, the node should be empty */
+	/* When hotadd a new node from cpu_up(), the node should be empty */
 	if (!node_start_pfn && !node_end_pfn)
 		return 0;
Signature · 1 line
2.0.0
Acked-by on v1 1/1
#1 lore raw
Quoted 4 lines · Xishi Qiu

When hotadd a node from add_memory(), we will add memblock first, so the node is not empty. But when from cpu_up(), the node should be empty.

Signed-off-by Xishi Qiu <[email protected]>
Acked-by David Rientjes <[email protected]>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>