Skip to contentSkip to conversation

ss format bug

PATCH Mike Saal 2 participants 2 messages Aug 26, 2015 – Aug 31, 2015

Subsystems (2)
lore
Share & tools
lore

Mike Saal

author
#0 lore raw

Hi:

I found a formatting bug in the 4.1.1 ss command. The following line was incorrectly output due to passing a negative length to printf() when displaying the local address. In this instance hostapd does a "bind to device" on cdreth0 and then does a udp "in address any" port 67 bind. Please note the whitespace between the '*' and ' %cdreth0:67'

'udp UNCONN 0 0 ** %cdreth0:67* *:* users:(("hostapd",pid=19241,fd=5))'

Attached is my patch for the bug fix, it might be prudent to add more guard code looking for negative length format codes.

Sincerely, Mike

misc/ss.c +2 -0
diff -Nuar iproute2-4.1.1.orig/misc/ss.c iproute2-4.1.1/misc/ss.c
@@ -1023,6 +1023,8 @@
 	if (ifindex) {
 		ifname   = ll_index_to_name(ifindex);
 		est_len -= strlen(ifname) + 1;  /* +1 for percent char */
+		if (est_len < 0)
+			est_len = 0;
 	}
 
 	sock_addr_print_width(est_len, ap, ":", serv_width, resolve_service(port),
#1 lore raw
Quoted 8 lines · On Wed, 26 Aug 2015 11:59:17 -0400 Mike Saal <[email protected]> wrote:

Hi:

I found a formatting bug in the 4.1.1 ss command. The following line was incorrectly output due to passing a negative length to printf() when displaying the local address. In this instance hostapd does a "bind to device" on cdreth0 and then does a udp "in address any" port 67 bind. Please note the whitespace between the '*' and ' %cdreth0:67'

Quoted 6 lines
    'udp UNCONN 0 0 ** %cdreth0:67* *:* users:(("hostapd",pid=19241,fd=5))'

Attached is my patch for the bug fix, it might be prudent to add more guard code looking for negative length format codes.

Sincerely, Mike

I think the root cause of this is actually down in the main program where it is computing addr_width. It is not accounting for the size correctly, or maybe your case just occurs if screen is too narrow to fit the full width.