pulseaudio: reduce 24s recording latency
PATCH 1/1 pulseaudio: reduce 24s recording latency
Current code doesn't provide pulseaudio buffer attributes for recording. Without buffer attributes pulseaudio uses a default buffer of 4MB. 4MB is approximately 24s 16bit stereo audio data at 44.1kHz.
This patch fixes bug #1492649
|Signed-off-by: Volker Rümelin <[email protected]>|
--- audio/paaudio.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)
audio/paaudio.c +8 -1
@@ -608,6 +608,7 @@ static int qpa_init_in(HWVoiceIn *hw, struct audsettings *as, void *drv_opaque) {int error;pa_sample_spec ss; +pa_buffer_attr ba;struct audsettings obt_as = *as;PAVoiceIn *pa = (PAVoiceIn *) hw;paaudio *g = pa->g = drv_opaque;
@@ -616,6 +617,12 @@ static int qpa_init_in(HWVoiceIn *hw, struct audsettings *as, void *drv_opaque) ss.channels = as->nchannels; ss.rate = as->freq; + ba.fragsize =pa_frame_size (&ss) * g->conf.samples; + ba.maxlength =5 * ba.fragsize; + ba.tlength =-1 ; + ba.prebuf =-1 ; + ba.minreq =-1 ; + obt_as.fmt =pa_to_audfmt (ss.format, &obt_as.endianness); pa->stream = qpa_simple_new (
@@ -625,7 +632,7 @@ static int qpa_init_in(HWVoiceIn *hw, struct audsettings *as, void *drv_opaque) g->conf.source, &ss,NULL ,/* channel map */ -NULL ,/* buffering attributes */ + &ba,/* buffering attributes */ &error );if (!pa->stream) {
Signature · 1 line
1.8.4.5
Hi
Quoted 4 lines · Volker Rümelin
Current code doesn't provide pulseaudio buffer attributes for recording. Without buffer attributes pulseaudio uses a default buffer of 4MB. 4MB is approximately 24s 16bit stereo audio data at 44.1kHz.
Why isn't the buffer processed as soon as some data is available?
Signature · 1 line
Marc-André Lureau
Hi,
Am 12.09.2015 um 01:22 schrieb Marc-André Lureau:
Quoted 7 lines
Quoted 4 lines
Current code doesn't provide pulseaudio buffer attributes for recording. Without buffer attributes pulseaudio uses a default buffer of 4MB. 4MB is approximately 24s 16bit stereo audio data at 44.1kHz.
Why isn't the buffer processed as soon as some data is available?
On start up qemu opens a connection to pulseaudio in function qpa_init_in and pulseaudio immediately starts recording to the 4MB ringbuffer. The qemu guest, Windows 8.1 in my case, doesn't consume that data if there is no process listening on the audio interface. Now if the guest starts recording, it will see audio data which was recorded 24s ago.
Regards,
Volker
Hi
Quoted 25 lines · Volker Rümelin
Current code doesn't provide pulseaudio buffer attributes for recording. Without buffer attributes pulseaudio uses a default buffer of 4MB. 4MB is approximately 24s 16bit stereo audio data at 44.1kHz.
This patch fixes bug #1492649
|Signed-off-by: Volker Rümelin <[email protected]>|
--- audio/paaudio.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)audio/paaudio.c +1
-0@@ -608,6 +608,7 @@ static int qpa_init_in(HWVoiceIn *hw, struct audsettings *as, void *drv_opaque) {int error;pa_sample_spec ss; +pa_buffer_attr ba;struct audsettings obt_as = *as;PAVoiceIn *pa = (PAVoiceIn *) hw;paaudio *g = pa->g = drv_opaque;
audio/paaudio.c static int qpa_init_in(HWVoiceIn *hw, struct audsettings *as, void *drv_opaque) · line 621
Quoted 5 lines
audio/paaudio.c +2
-0@@ -616,6 +617,12 @@ static int qpa_init_in(HWVoiceIn *hw, struct audsettings *as, void *drv_opaque) ss.channels = as->nchannels; ss.rate = as->freq; + ba.fragsize =pa_frame_size (&ss) * g->conf.samples; + ba.maxlength =5 * ba.fragsize;
This 5 value is a bit arbitrary, I suppose it may increase max latency up to 5 times the g->conf.samples. (what about using PA_STREAM_ADJUST_LATENCY?)
Otherwise, the change looks good to me.
Quoted 20 lines
audio/paaudio.c +5
-2+ ba.tlength =-1 ; + ba.prebuf =-1 ; + ba.minreq =-1 ; + obt_as.fmt =pa_to_audfmt (ss.format, &obt_as.endianness); pa->stream = qpa_simple_new (@@ -625,7 +632,7 @@ static int qpa_init_in(HWVoiceIn *hw, struct audsettings *as, void *drv_opaque) g->conf.source, &ss,NULL ,/* channel map */ -NULL ,/* buffering attributes */ + &ba,/* buffering attributes */ &error );if (!pa->stream) { --1.8.4.5
Signature · 1 line
Marc-André Lureau
2015-09-12 13:23 keltezéssel, Volker Rümelin írta:
Quoted 12 lines
Hi,
Am 12.09.2015 um 01:22 schrieb Marc-André Lureau:
Quoted 7 lines
Quoted 4 lines
Current code doesn't provide pulseaudio buffer attributes for recording. Without buffer attributes pulseaudio uses a default buffer of 4MB. 4MB is approximately 24s 16bit stereo audio data at 44.1kHz.
Why isn't the buffer processed as soon as some data is available?
Quoted 5 lines
On start up qemu opens a connection to pulseaudio in function
qpa_init_inand pulseaudio immediately starts recording to the 4MB ringbuffer. The qemu guest, Windows 8.1 in my case, doesn't consume that data if there is no process listening on the audio interface. Now if the guest starts recording, it will see audio data which was recorded 24s ago.
Weird, pulseaudio shouldn't delay the input more than 2 seconds in the default config. Maybe PA_STREAM_EARLY_REQUESTS help. See my patch at [1]. Alternatively we should maybe call pa_stream_flush when enabling the input to tell pulseaudio to drop previously recorded samples.
[1]: https://lists.gnu.org/archive/html/qemu-devel/2015-08/msg02455.html
Zoltan
Am 12.09.2015 um 16:35 schrieb Kővágó Zoltán:
Quoted 8 lines
2015-09-12 13:23 keltezéssel, Volker Rümelin írta:
Quoted 6 lines
On start up qemu opens a connection to pulseaudio in function
qpa_init_inand pulseaudio immediately starts recording to the 4MB ringbuffer. The qemu guest, Windows 8.1 in my case, doesn't consume that data if there is no process listening on the audio interface. Now if the guest starts recording, it will see audio data which was recorded 24s ago.
Quoted 4 lines
Weird, pulseaudio shouldn't delay the input more than 2 seconds in the default config. Maybe
PA_STREAM_EARLY_REQUESTShelp. See my patch at [1]. Alternatively we should maybe callpa_stream_flushwhen enabling the input to tell pulseaudio to drop previously recorded samples.[1]: https://lists.gnu.org/archive/html/qemu-devel/2015-08/msg02455.html
Hi Zoltan,
I tested your suggestions.
There was the same 24s latency when I replaced PA_STREAM_ADJUST_LATENCY with PA_STREAM_EARLY_REQUESTS in function pa_stream_connect_record. This was to be expected, because the pulseaudio documentation only mentions playback there.
A call to pa_stream_flush in qpa_ctl_in in case VOICE_ENABLE: also didn't solve the problem.
But when I replaced pa_stream_flush with a repeated call to pa_stream_peek and pa_stream_drop things started to improve. Now I experience the 1-2s recording latency mentioned in the pulseaudio documentation. But this is still much higher than the latency I see with my old patch.
Regards,
Volker