Skip to contentSkip to conversation

settimeofday01:TFAIL in Kernel 4.2.0

LTP Takeshi Misawa 2 participants 4 messages Sep 13, 2015 – Sep 24, 2015

lore
Share & tools
lore

Takeshi Misawa

author
#0 lore raw

This is a my first mail to LTP mailing list.

I'm testing Linux Kernel 4.2.0 by LTP. I saw a following Error.
-----
settimeofday01 1 TFAIL : settimeofday01.c:98: Error Setting Time,
errno=22

settimeofday01    2  TFAIL  :  settimeofday01.c:120: Test condition 1 failed
settimeofday01    3  TPASS  :  Test condition 2 successful

-----

In commit of Linux Kernel:
e1d7ba8735551ed79c7a0463a042353574b96da3 "time: Always make sure wall_to_monotonic isn't positive"
add a new check to do_settimeofday64().

This commit said:
"As a result one can't set the CLOCK_REALTIME time prior to (1970 + system uptime)."

In settimeofday01 test case, parameter of first settimeofday() is 100s100μs. A lot of cases, TEST_RETURN is -1.

I'd better to modify settimeofday01 test case.

To meet that requirement, I made following changes.(I have less confidence that it is correct...)
-----

(quoted diff) +0 -0

b/testcases/kernel/syscalls/settimeofday
index b598800..a6894fb 100644

testcases/kernel/syscalls/settimeofday/settimeofday01.c +4 -3
@@ -88,9 +88,10 @@ int main(int argc, char **argv)
               int condition_number = 1;
               /* reset tst_count in case we are looping */
               tst_count = 0;
-
-               tp.tv_sec = VAL_SEC;
-               tp.tv_usec = VAL_MSEC;
+
+               gettimeofday(&tp, NULL);
+               tp.tv_sec += VAL_SEC;
+               tp.tv_usec += VAL_MSEC;
 
               TEST(settimeofday(&tp, NULL));
               if (TEST_RETURN == -1) {

----

Result:

settimeofday01    1  TPASS  :  Test condition 1 successful
settimeofday01    2  TPASS  :  Test condition 2 successful

Thanks.

------------------------------------------------------------------------------
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

#1 lore raw

Hi!

Quoted 19 lines

This is a my first mail to LTP mailing list.

I'm testing Linux Kernel 4.2.0 by LTP. I saw a following Error.
-----
settimeofday01 1 TFAIL : settimeofday01.c:98: Error Setting Time,
errno=22

settimeofday01    2  TFAIL  :  settimeofday01.c:120: Test condition 1 failed
settimeofday01    3  TPASS  :  Test condition 2 successful

-----

In commit of Linux Kernel:
e1d7ba8735551ed79c7a0463a042353574b96da3 "time: Always make sure wall_to_monotonic isn't positive"
add a new check to do_settimeofday64().

This commit said:
"As a result one can't set the CLOCK_REALTIME time prior to (1970 + system uptime)."

Quoted 7 lines

In settimeofday01 test case, parameter of first settimeofday() is 100s100??s. A lot of cases, TEST_RETURN is -1.

I'd better to modify settimeofday01 test case.

To meet that requirement, I made following changes.(I have less confidence that it is correct...)

The patch looks good but does not apply since the the whitespaces are corrupted. Can you please resend correct one with a better changelog and Signed-off-by line? (set you name and email in git, then use git commit -s and git format-patch -1 and send the result)

Also the mailing list has moved to [email protected], please use that one from now on.

Signature · 2 lines
Cyril Hrubis
[email protected]
author
#2 lore raw
Quoted 28 lines

Hi!

Quoted 19 lines

This is a my first mail to LTP mailing list.

I'm testing Linux Kernel 4.2.0 by LTP. I saw a following Error.
-----
settimeofday01 1 TFAIL : settimeofday01.c:98: Error Setting Time,
errno=22

settimeofday01    2  TFAIL  :  settimeofday01.c:120: Test condition 1 failed
settimeofday01    3  TPASS  :  Test condition 2 successful

-----

In commit of Linux Kernel:
e1d7ba8735551ed79c7a0463a042353574b96da3 "time: Always make sure wall_to_monotonic isn't positive"
add a new check to do_settimeofday64().

This commit said:
"As a result one can't set the CLOCK_REALTIME time prior to (1970 + system uptime)."

Quoted 7 lines

In settimeofday01 test case, parameter of first settimeofday() is 100s100??s. A lot of cases, TEST_RETURN is -1.

I'd better to modify settimeofday01 test case.

To meet that requirement, I made following changes.(I have less confidence that it is correct...)

Quoted 8 lines

The patch looks good but does not apply since the the whitespaces are corrupted. Can you please resend correct one with a better changelog and Signed-off-by line? (set you name and email in git, then use git commit -s and git format-patch -1 and send the result)

Also the mailing list has moved to [email protected], please use that one from now on.

Thank you for reply and kindly advice.

I resent a patch. (Sorry for my late reply.)

Thanks
-------------- next part --------------
A non-text attachment was scrubbed...
Name: settimeofday01-fix-settimeofday-argument-4.2.patch
Type: text/x-patch
Size: 1371 bytes
Desc: not available
URL: <http://lists.linux.it/pipermail/ltp/attachments/20150919/a0536233/attachment.bin>

#3 lore raw

Hi!

Quoted 3 lines

Thank you for reply and kindly advice.

I resent a patch. (Sorry for my late reply.)

Pushed with minor changes to the commit message, thanks.

Signature · 2 lines
Cyril Hrubis
[email protected]