Skip to contentSkip to conversation

Possible Bug in move_encrypted_block

DISCUSSION nick 2 participants 2 messages Sep 19, 2015 – Sep 21, 2015

lore
Share & tools
lore

nick

author
#0 lore raw

Greetings Jaeguek and others.
Below are the lines fora possible bug in move_encrypted_block:

err = get_dnode_of_data(&dn, bidx, LOOKUP_NODE);
        if (err)
                goto out;

Also calls of get_dnode_of_data need to hold the semaphone for the superblock this call is being done on to avoid concurrent access on data being received here from the superblock and file system on disk. In addition unless I get a reply to this I will not be sending in a bug fix for this.
Nick

------------------------------------------------------------------------------

#1 lore raw

Hi,

Quoted 7 lines · nick

Greetings Jaeguek and others.
Below are the lines fora possible bug in move_encrypted_block:

err = get_dnode_of_data(&dn, bidx, LOOKUP_NODE);
        if (err)
                goto out;

Also calls of get_dnode_of_data need to hold the semaphone for the superblock this call is being done on to avoid concurrent access on data being received

IIUC, the f2fs_lock_op() is not neeeded here. Do you mean this? To be honest, I can't catch your point.

Thanks,

Quoted 3 lines

here from the superblock and file system on disk. In addition unless I get a reply to this I will not be sending in a bug fix for this.
Nick