Skip to contentSkip to conversation

NFS: Do cleanup before resetting pageio read/write to mds

PATCH New Kinglong Mee 1 participant 1 message Sep 20, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 NFS: Do cleanup before resetting pageio read/write to mds

There is a reference leak of layout segment after resetting pageio read/write to mds.

---
 fs/nfs/read.c  | 3 +++
 fs/nfs/write.c | 3 +++
 2 files changed, 6 insertions(+)
fs/nfs/read.c +3 -0
index ae0ff7a..01b8cc8 100644
@@ -72,6 +72,9 @@ void nfs_pageio_reset_read_mds(struct nfs_pageio_descriptor *pgio)
 {
 	struct nfs_pgio_mirror *mirror;
 
+	if (pgio->pg_ops && pgio->pg_ops->pg_cleanup)
+		pgio->pg_ops->pg_cleanup(pgio);
+
 	pgio->pg_ops = &nfs_pgio_rw_ops;
 
 	/* read path should never have more than one mirror */
fs/nfs/write.c +3 -0
index 388f480..72624dc 100644
@@ -1351,6 +1351,9 @@ void nfs_pageio_reset_write_mds(struct nfs_pageio_descriptor *pgio)
 {
 	struct nfs_pgio_mirror *mirror;
 
+	if (pgio->pg_ops && pgio->pg_ops->pg_cleanup)
+		pgio->pg_ops->pg_cleanup(pgio);
+
 	pgio->pg_ops = &nfs_pgio_rw_ops;
 
 	nfs_pageio_stop_mirroring(pgio);
Signature · 1 line
2.5.0