Skip to contentSkip to conversation

ARM: pxa: magician: Rework HTC Magician support

PATCH In review Petr Cvek 3 participants 6 messages Sep 28, 2015 – Oct 12, 2015

lore
Share & tools
lore

Petr Cvek

author
#0 lore raw

v4 cover ARM: pxa: magician: Rework HTC Magician support

This patchset will clean, fix, optimize and add multiple devices, which can be found on the HTC Magician machine.

Platform data for the pasic3-leds driver has been removed, as this driver do not exist in the vanilla. And it is expected to be recreated in the future with an incompatible platform data structure.

Default setting of the Samsung LCD pixel clock period has been increased, so resulting frequency is 50Hz (original 117Hz). Period can be possibly incresed even more. At this moment there is no video player with IWMMXT support and software only versions cannot make it to 30fps. Frequency decreasing has a good impact to memory troughtput as LCD controller does not do as many memory bursts as at original speed. This was verified with the lat_mem_rd from the lmbench3.

The Omnivision OV9640 camera has a problem with running on 400kHz of the I2C clock. It seems it freezes the bus until PXA I2C driver reload. Datasheet says it OK on 400kHz though. There may be some compatibility bug in the PXA I2C driver as Omnivision cameras often uses special I2C protocol (SCCB).

Using the CPU frequency scaling (with help of an MAX1587A regulator) sometimes causes an SoC failure. It is probably related to the PXA27x erratum E37, E36, E80 or E89. Infreqent changes mostly works.

STUART removal is a prepare for:

net: irda: pxaficp_ir: dmaengine conversion

Function was tested on the board_id 0x3a version (specifically on the T-Mobile MDA compact).

Changes from v3:
* Nontrivial rebase for indentation fixup (EGPIO and PXA UDC)

Petr Cvek (26):
ARM: pxa: magician: Fix indentation in machine files
ARM: pxa: magician: Change comments to be more informative
ARM: pxa: magician: Print more specific error message for global
GPIOs
ARM: pxa: magician: Optimize debug messages for LCD power
ARM: pxa: magician: Change description of LCD power GPIO
ARM: pxa: magician: Add new discovered EGPIO pins
ARM: pxa: magician: Fix HTC Magician pin mux definitions
ARM: pxa: magician: Rename abstract LCD GPIOs
ARM: pxa: magician: Optimize powerup delays for Samsung LCD
ARM: pxa: magician: Optimize Samsung LCD refresh to 50Hz
ARM: pxa: magician: Optimize EGPIO initial values
ARM: pxa: magician: Rename charger cable detection EGPIOs
ARM: pxa: magician: Fix and add charging detection functions
ARM: pxa: magician: Fix platform data for both PXA27x I2C controllers
ARM: pxa: magician: Fix redundant GPIO request for pxaficp_ir
ARM: pxa: magician: Fix support for Intel Strata NOR Flash
ARM: pxa: magician: Fix wrongly enabled USB host ports
ARM: pxa: magician: Add support for ADS7846
ARM: pxa: magician: Add support for Omnivision OV9640 camera
ARM: pxa: magician: Add support for MAX1587A Vcore regulator
ARM: pxa: magician: Add support for PXA27x UDC
ARM: pxa: magician: Remove pdata for pasic3-leds
ARM: pxa: magician: Remove definition of the STUART port
ARM: pxa: magician: Add debug message for backlight brightness
function
ARM: pxa: magician: Add missing regulator for PWM backlight
ARM: pxa: magician: Move platform_add_devices() to the end of
magician_init()

 arch/arm/mach-pxa/include/mach/magician.h |  70 ++-
 arch/arm/mach-pxa/magician.c              | 907 +++++++++++++++++++++---------
 2 files changed, 678 insertions(+), 299 deletions(-)
Signature · 1 line
1.7.12.1
#1 lore raw

Hi!

Quoted 21 lines

This patchset will clean, fix, optimize and add multiple devices, which can be found on the HTC Magician machine.

Platform data for the pasic3-leds driver has been removed, as this driver do not exist in the vanilla. And it is expected to be recreated in the future with an incompatible platform data structure.

Default setting of the Samsung LCD pixel clock period has been increased, so resulting frequency is 50Hz (original 117Hz). Period can be possibly incresed even more. At this moment there is no video player with IWMMXT support and software only versions cannot make it to 30fps. Frequency decreasing has a good impact to memory troughtput as LCD controller does not do as many memory bursts as at original speed. This was verified with the lat_mem_rd from the lmbench3.

The Omnivision OV9640 camera has a problem with running on 400kHz of the I2C clock. It seems it freezes the bus until PXA I2C driver reload. Datasheet says it OK on 400kHz though. There may be some compatibility bug in the PXA I2C driver as Omnivision cameras often uses special I2C protocol (SCCB).

Quoted 3 lines

Using the CPU frequency scaling (with help of an MAX1587A regulator) sometimes causes an SoC failure. It is probably related to the PXA27x erratum E37, E36, E80 or E89. Infreqent changes mostly works.

Nice to see work done on a cellphone...

Seeing all the GPIO name changes... would it be possible / make sense to make to device tree one day?

What userspace do you run on the phone? Can it do calls?

[I have N900 here, kernel is in pretty good state, and I have Mate desktop running with python application for calls, but...]

Thanks (a pozdrav :-),

Pavel

Quoted 53 lines

STUART removal is a prepare for:

net: irda: pxaficp_ir: dmaengine conversion

Function was tested on the board_id 0x3a version (specifically on the T-Mobile MDA compact).

Changes from v3:
* Nontrivial rebase for indentation fixup (EGPIO and PXA UDC)

Petr Cvek (26):
ARM: pxa: magician: Fix indentation in machine files
ARM: pxa: magician: Change comments to be more informative
ARM: pxa: magician: Print more specific error message for global
GPIOs
ARM: pxa: magician: Optimize debug messages for LCD power
ARM: pxa: magician: Change description of LCD power GPIO
ARM: pxa: magician: Add new discovered EGPIO pins
ARM: pxa: magician: Fix HTC Magician pin mux definitions
ARM: pxa: magician: Rename abstract LCD GPIOs
ARM: pxa: magician: Optimize powerup delays for Samsung LCD
ARM: pxa: magician: Optimize Samsung LCD refresh to 50Hz
ARM: pxa: magician: Optimize EGPIO initial values
ARM: pxa: magician: Rename charger cable detection EGPIOs
ARM: pxa: magician: Fix and add charging detection functions
ARM: pxa: magician: Fix platform data for both PXA27x I2C controllers
ARM: pxa: magician: Fix redundant GPIO request for pxaficp_ir
ARM: pxa: magician: Fix support for Intel Strata NOR Flash
ARM: pxa: magician: Fix wrongly enabled USB host ports
ARM: pxa: magician: Add support for ADS7846
ARM: pxa: magician: Add support for Omnivision OV9640 camera
ARM: pxa: magician: Add support for MAX1587A Vcore regulator
ARM: pxa: magician: Add support for PXA27x UDC
ARM: pxa: magician: Remove pdata for pasic3-leds
ARM: pxa: magician: Remove definition of the STUART port
ARM: pxa: magician: Add debug message for backlight brightness
function
ARM: pxa: magician: Add missing regulator for PWM backlight
ARM: pxa: magician: Move platform_add_devices() to the end of
magician_init()

 arch/arm/mach-pxa/include/mach/magician.h |  70 ++-
 arch/arm/mach-pxa/magician.c              | 907 +++++++++++++++++++++---------
 2 files changed, 678 insertions(+), 299 deletions(-)
Signature · 7 lines
1.7.12.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
author
#2 lore raw

Dne 6.10.2015 v 17:25 Pavel Machek napsal(a):

Quoted 1 line

Hi!

Ahoj :-),

Quoted 22 lines
Quoted 22 lines

This patchset will clean, fix, optimize and add multiple devices, which can be found on the HTC Magician machine.

Platform data for the pasic3-leds driver has been removed, as this driver do not exist in the vanilla. And it is expected to be recreated in the future with an incompatible platform data structure.

Default setting of the Samsung LCD pixel clock period has been increased, so resulting frequency is 50Hz (original 117Hz). Period can be possibly incresed even more. At this moment there is no video player with IWMMXT support and software only versions cannot make it to 30fps. Frequency decreasing has a good impact to memory troughtput as LCD controller does not do as many memory bursts as at original speed. This was verified with the lat_mem_rd from the lmbench3.

The Omnivision OV9640 camera has a problem with running on 400kHz of the I2C clock. It seems it freezes the bus until PXA I2C driver reload. Datasheet says it OK on 400kHz though. There may be some compatibility bug in the PXA I2C driver as Omnivision cameras often uses special I2C protocol (SCCB).

Quoted 8 lines
Quoted 3 lines

Using the CPU frequency scaling (with help of an MAX1587A regulator) sometimes causes an SoC failure. It is probably related to the PXA27x erratum E37, E36, E80 or E89. Infreqent changes mostly works.

Nice to see work done on a cellphone...

Seeing all the GPIO name changes... would it be possible / make sense to make to device tree one day?

Probably, but there are still some missing parts (camera, usb webcam gadget, sound, leds, gsm GPIOs)

Quoted 2 lines

What userspace do you run on the phone? Can it do calls?

I have found it is faster and funny to create from scratch (and openmoko image is too old), so I've built it by Buildroot:

Busybox, Xorg and Matchbox, but as GTK apps are not too good for 240x320 resolution I have made my own "GUI" (so I can control Magician even without any USB/IrDA connection).

Calls are planned but by now I'm receiving SMS by hand by writing AT commands :-D.

Quoted 3 lines

[I have N900 here, kernel is in pretty good state, and I have Mate desktop running with python application for calls, but...]

Magician is very limited by RAM (64MB + 64MB Flash), so I can only have C applications (or shell :-D).

Quoted 58 lines

Thanks (a pozdrav :-),

Pavel

Quoted 53 lines

STUART removal is a prepare for:

net: irda: pxaficp_ir: dmaengine conversion

Function was tested on the board_id 0x3a version (specifically on the T-Mobile MDA compact).

Changes from v3:
* Nontrivial rebase for indentation fixup (EGPIO and PXA UDC)

Petr Cvek (26):
ARM: pxa: magician: Fix indentation in machine files
ARM: pxa: magician: Change comments to be more informative
ARM: pxa: magician: Print more specific error message for global
GPIOs
ARM: pxa: magician: Optimize debug messages for LCD power
ARM: pxa: magician: Change description of LCD power GPIO
ARM: pxa: magician: Add new discovered EGPIO pins
ARM: pxa: magician: Fix HTC Magician pin mux definitions
ARM: pxa: magician: Rename abstract LCD GPIOs
ARM: pxa: magician: Optimize powerup delays for Samsung LCD
ARM: pxa: magician: Optimize Samsung LCD refresh to 50Hz
ARM: pxa: magician: Optimize EGPIO initial values
ARM: pxa: magician: Rename charger cable detection EGPIOs
ARM: pxa: magician: Fix and add charging detection functions
ARM: pxa: magician: Fix platform data for both PXA27x I2C controllers
ARM: pxa: magician: Fix redundant GPIO request for pxaficp_ir
ARM: pxa: magician: Fix support for Intel Strata NOR Flash
ARM: pxa: magician: Fix wrongly enabled USB host ports
ARM: pxa: magician: Add support for ADS7846
ARM: pxa: magician: Add support for Omnivision OV9640 camera
ARM: pxa: magician: Add support for MAX1587A Vcore regulator
ARM: pxa: magician: Add support for PXA27x UDC
ARM: pxa: magician: Remove pdata for pasic3-leds
ARM: pxa: magician: Remove definition of the STUART port
ARM: pxa: magician: Add debug message for backlight brightness
function
ARM: pxa: magician: Add missing regulator for PWM backlight
ARM: pxa: magician: Move platform_add_devices() to the end of
magician_init()

 arch/arm/mach-pxa/include/mach/magician.h |  70 ++-
 arch/arm/mach-pxa/magician.c              | 907 +++++++++++++++++++++---------
 2 files changed, 678 insertions(+), 299 deletions(-)
Signature · 7 lines
1.7.12.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#3 lore raw
Quoted 3 lines · Petr Cvek
Quoted 3 lines

Thanks (a pozdrav :-),

Pavel

Hi Petr,

I'll start applying part of this serie today evening (my evening). All Philipp's acked patches for a start.

For the minor changes required by Philipp (comments, ...), if you just state by mail that you agree I'll make them inline before applying.

Cheers.

--
Robert

#4 lore raw
Quoted 10 lines · Robert Jarzmik
Quoted 3 lines · Petr Cvek
Quoted 3 lines

Thanks (a pozdrav :-),

Pavel

Hi Petr,

I'll start applying part of this serie today evening (my evening). All Philipp's acked patches for a start.

Quoted 7 lines

For the minor changes required by Philipp (comments, ...), if you just state by mail that you agree I'll make them inline before applying.

Cheers.

--
Robert

Ok, applied and pushed out in pxa/for-next
https://github.com/rjarzmik/linux.git pxa/for-next :

425c97c3c937 ARM: pxa: magician: Move platform_add_devices() to the end of magician_init() 3b1c0c4ae8fd ARM: pxa: magician: Add missing regulator for PWM backlight 452f1945c9b7 ARM: pxa: magician: Add debug message for backlight brightness function 20c1c7bb35c2 ARM: pxa: magician: Remove definition of the STUART port 3181b4a3815d ARM: pxa: magician: Fix wrongly enabled USB host ports ba79d845999d ARM: pxa: magician: Fix support for Intel Strata NOR Flash d62591e4e5d1 ARM: pxa: magician: Fix redundant GPIO request for pxaficp_ir d73219de5868 ARM: pxa: magician: Fix platform data for both PXA27x I2C controllers 48e112eb54eb ARM: pxa: magician: Fix and add charging detection functions 65cd6cc24910 ARM: pxa: magician: Optimize Samsung LCD refresh to 50Hz c85c66dbc212 ARM: pxa: magician: Rename charger cable detection EGPIOs 6fd9d402d8c4 ARM: pxa: magician: Optimize powerup delays for Samsung LCD e391a4d95dd4 ARM: pxa: magician: Rename abstract LCD GPIOs
32bed563d51f ARM: pxa: magician: Add new discovered EGPIO pins
ab558b6c5834 ARM: pxa: magician: Change description of LCD power GPIO c1ed9f57e853 ARM: pxa: magician: Optimize debug messages for LCD power 33e910e79b77 ARM: pxa: magician: Print more specific error message for global GPIOs 4c006b908a07 ARM: pxa: magician: Fix indentation in machine files

That leaves out 8 patches, for you to :
- either resubmit (rebased on top of the pxa/for-next tree)
- or drop (mostly because of Philipp's NACK or the camera reset)

This way your next submission should be quite shorter and easy to manage.

Cheers.

Signature · 1 line
Robert
author
#5 lore raw
In reply to Robert Jarzmik

Dne 11.10.2015 v 10:22 Robert Jarzmik napsal(a):

Quoted 4 lines
Quoted 2 lines · Petr Cvek
Quoted 2 lines

Thanks (a pozdrav :-),

Quoted 8 lines
Quoted 1 line
Quoted 1 line

Pavel

Hi Petr,

I'll start applying part of this serie today evening (my evening). All Philipp's acked patches for a start.

For the minor changes required by Philipp (comments, ...), if you just state by mail that you agree I'll make them inline before applying.

Yes they are OK with me.

Petr Cvek