Skip to contentSkip to conversation

m25p80: Commit "allow arbitrary OF matching for "jedec,spi-nor"" breaks module autoloading

DISCUSSION Heiner Kallweit 2 participants 2 messages Oct 3, 2015 1 message not in the archive SPI

lore
Share & tools
lore
#0 lore raw

Seems like commit 43163022927b6e7d202a7e6f939c3f392465494d (allow arbitrary OF matching for "jedec,spi-nor") broke autoloading of the m25p80 module.
MODALIAS is "spi:spi-nor" and removing "spi-nor" as device alias prevents module autoloading.

Of course we could revert the removal of the "spi-nor" device alias. However it might be better to switch to DT-based matching for DT-configured devices.

Adding a call to of_device_uevent_modalias to spi_uevent in spi.c solved the issue for me, drawback however is that just the first "compatible" value is used as modalias. In case of m25p80 this means that "jedec,spi-nor" has to be the first "compatible" value. This constraint might be too strict ..

Having said that I'm not sure what could be a better way to fix the issue than just re-introducing the "spi-nor" device alias. --
To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

#2 lore raw
In reply to a message not in the archive
Quoted 5 lines · Heiner Kallweit

Seems like commit 43163022927b6e7d202a7e6f939c3f392465494d (allow arbitrary OF matching for "jedec,spi-nor") broke autoloading of the m25p80 module.
MODALIAS is "spi:spi-nor" and removing "spi-nor" as device alias prevents module autoloading.

You probably want to ask Brian or other people working on NOR about this - I'm not entirely sure why you've sent this to either me or the SPI list...