Skip to contentSkip to conversation

Patches are stuck in master-next

DISCUSSION Christian Eggers 3 participants 8 messages Jul 8, 2020

lore
Share & tools
lore
#0 lore raw

Two of my patches are in master-next since some time. Is there any reason why they don't appear in master?

https://patchwork.openembedded.org/series/24760/#
https://patchwork.openembedded.org/series/24775/#

I would like to send further patches for meta-openembedded which depend on the above ones.

regards
Christian

________________________________
[http://assets.arri.com/media/sign/2020-04-03-E-mail-signature-Stellar2_V1.jpg] <https://microsites.arri.com/stellar/>

Get all the latest information from www.arri.com<https://www.arri.com/>, Facebook<https://www.facebook.com/TeamARRI>, Twitter<https://twitter.com/ARRIChannel>, Instagram<https://instagram.com/arri> and YouTube<https://www.youtube.com/user/ARRIChannel>.

Arnold & Richter Cine Technik GmbH & Co. Betriebs KG
Sitz: München - Registergericht: Amtsgericht München - Handelsregisternummer: HRA 57918 Persönlich haftender Gesellschafter: Arnold & Richter Cine Technik GmbH
Sitz: München - Registergericht: Amtsgericht München - Handelsregisternummer: HRB 54477 Geschäftsführer: Dr. Michael Neuhäuser; Stephan Schenk; Walter Trauninger; Markus Zeiler

#1 lore raw
Quoted 9 lines · Christian Eggers

Two of my patches are in master-next since some time. Is there any reason why
they don't appear in master?

https://patchwork.openembedded.org/series/24760/#
https://patchwork.openembedded.org/series/24775/#

I would like to send further patches for meta-openembedded which depend on the above ones.

The issue is I still don't really like the eudev one in particular. A native eudev really doesn't make sense and I'm reluctant to encourage people to build such a thing. I suspect you can't convince networkmanager-native to build without it (although I'm not convinced a native libnm is that useful either).

Cheers,

Richard

#2 lore raw

Hi Richard,

Am Mittwoch, 8. Juli 2020, 11:20:40 CEST schrieb Richard Purdie:

Quoted 5 lines

The issue is I still don't really like the eudev one in particular. A native eudev really doesn't make sense and I'm reluctant to encourage people to build such a thing. I suspect you can't convince networkmanager-native to build without it (although I'm not convinced a native libnm is that useful either).

For NATIVESDK, I need the libs because I deploy a x86 version of our embedded application for our internal integration test team. Sure, I could built two cross SDKs (one for ARM, one for x86), but (mis?)using NATIVESDK for getting the x86 version of our applications works very fine for me.

For NATIVE, I need the libs for running automatic unit tests on the build machine. One could probably ask whether unit tests should depend on libraries like libudev or libnm.

Please let me know, which of the additions (NATIVE / NATIVESDK) are welcome. I'm only offering to share my work, I'm also fine keeping this in my private layer.

regards
Christian

________________________________
[http://assets.arri.com/media/sign/2020-04-03-E-mail-signature-Stellar2_V1.jpg] <https://microsites.arri.com/stellar/>

Get all the latest information from www.arri.com<https://www.arri.com/>, Facebook<https://www.facebook.com/TeamARRI>, Twitter<https://twitter.com/ARRIChannel>, Instagram<https://instagram.com/arri> and YouTube<https://www.youtube.com/user/ARRIChannel>.

Arnold & Richter Cine Technik GmbH & Co. Betriebs KG
Sitz: München - Registergericht: Amtsgericht München - Handelsregisternummer: HRA 57918 Persönlich haftender Gesellschafter: Arnold & Richter Cine Technik GmbH
Sitz: München - Registergericht: Amtsgericht München - Handelsregisternummer: HRB 54477 Geschäftsführer: Dr. Michael Neuhäuser; Stephan Schenk; Walter Trauninger; Markus Zeiler

#3 lore raw
Quoted 18 lines · Christian Eggers

Am Mittwoch, 8. Juli 2020, 11:20:40 CEST schrieb Richard Purdie:

Quoted 8 lines

The issue is I still don't really like the eudev one in particular. A
native eudev really doesn't make sense and I'm reluctant to encourage
people to build such a thing. I suspect you can't convince networkmanager-native to build without it (although I'm not convinced
a native libnm is that useful either).

For NATIVESDK, I need the libs because I deploy a x86 version of our embedded application for our internal integration test team. Sure, I
could built two cross SDKs (one for ARM, one for x86), but (mis?)using
NATIVESDK for getting the x86 version of our applications works very fine for me.

Quoted 7 lines

For NATIVE, I need the libs for running automatic unit tests on the build machine. One could probably ask whether unit tests should depend on libraries like libudev or libnm.

Please let me know, which of the additions (NATIVE / NATIVESDK) are welcome. I'm only offering to share my work, I'm also fine keeping this in my private layer.

I don't mind taking the libnl change, I can see reasons that could make sense. I think the eudev change is a little too specific to your use case and isn't something that makes sense in OE-Core so I think I'd prefer to not take that one.

If large numbers of people come forward saying they need/use it, we can reconsider that but we're not seeing that at the moment.

Cheers,

Richard

#4 lore raw
In reply to Christian Eggers
Quoted 5 lines · Christian Eggers

...
For NATIVE, I need the libs for running automatic unit tests on the build machine. One could probably ask whether unit tests should depend on libraries like libudev or libnm.
...

I would rather ask why you aren't running automatic unit tests built for the target inside qemu.

Quoted 2 lines

regards
Christian

cu
Adrian

#5 lore raw

Am Mittwoch, 8. Juli 2020, 16:20:03 CEST schrieb Adrian Bunk:

Quoted 5 lines

I would rather ask why you aren't running automatic unit tests built for the target inside qemu.

cu
Adrian

This may be an option. Currently the platform (x86 or arm) decides whether real peripheral routines or mock objects will be used. Of course this can easily be changed. But running the tests within a (slow) emulator brings not much benefit compared to building and running the tests directly on x86.

Instead of using NATIVE, also the NATIVESDK build could be executed within qemu on the build machine... (without qemu, nativesdk executables cannot be executed on the build machine due to non existing loader in .interp section).

From Richard I got no response to the question whether potentially every package may be extended for nativesdk/native, or these platforms a reserved for packages required for "building".

regards
Christian

________________________________
[http://assets.arri.com/media/sign/2020-04-03-E-mail-signature-Stellar2_V1.jpg] <https://microsites.arri.com/stellar/>

Get all the latest information from www.arri.com<https://www.arri.com/>, Facebook<https://www.facebook.com/TeamARRI>, Twitter<https://twitter.com/ARRIChannel>, Instagram<https://instagram.com/arri> and YouTube<https://www.youtube.com/user/ARRIChannel>.

Arnold & Richter Cine Technik GmbH & Co. Betriebs KG
Sitz: München - Registergericht: Amtsgericht München - Handelsregisternummer: HRA 57918 Persönlich haftender Gesellschafter: Arnold & Richter Cine Technik GmbH
Sitz: München - Registergericht: Amtsgericht München - Handelsregisternummer: HRB 54477 Geschäftsführer: Dr. Michael Neuhäuser; Stephan Schenk; Walter Trauninger; Markus Zeiler

#6 lore raw
Quoted 3 lines · Christian Eggers

From Richard I got no response to the question whether potentially every package may be extended for nativesdk/native, or these platforms a reserved for packages required for "building".

There needs to be a sensible use case for extending them. It doesn't come for free and increases parse time for each extension added.

Cheers,

Richard

#7 lore raw
Quoted 7 lines · Richard Purdie
Quoted 3 lines · Christian Eggers

From Richard I got no response to the question whether potentially every package may be extended for nativesdk/native, or these platforms a reserved for packages required for "building".

There needs to be a sensible use case for extending them. It doesn't come for free and increases parse time for each extension added.

My biggest worry is a different one:

Native is built by the host compiler, and Yocto stable series aim at supporting hosts with future distributions. Something like "building dunfell on hosts with gcc 11" is easier when there are fewer recipes that have to be patched.

Quoted 3 lines

Cheers,

Richard

cu
Adrian