babeltrace foreign builds broken by 384246569494
Hi Nathan,
This should be fixed as of:
commit d620c28807ba2f9d0b97582384915f6a452a3375
Author: Jérémie Galarneau <[email protected]> Date: Fri Oct 16 15:31:28 2015 -0400
Fix: missing includes break the out-of-tree build
Addresses out-of-tree build breakage introduced by commit 3842465694945829d76452ff83924aa0103c6293
Thanks for reporting!
Jérémie
Quoted 25 lines · Nathan Lynch
Hi,
Building babeltrace's master branch in a directory separate from the source directory has been broken by:
commit
3842465694945829d76452ff83924aa0103c6293Author: Michael Jeanson <[email protected]> Date: Fri Oct 9 15:50:25 2015 -0400Port: Include
config.hglobally troughDEFAULT_INCLUDESSigned-off-by Michael Jeanson <[email protected]>Signed-off-by Jérémie Galarneau <[email protected]>The error is:
make[5]: Entering directory '
/home/nathanl/src/babeltrace/build/formats/ctf/metadata'/bin/sh../../../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I/home/nathanl/src/babeltrace/build/.. -I../../.. -I../../../include -includeconfig.h-pthread -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -Wall -Wformat -I/home/nathanl/src/babeltrace/build/../include -includectf-scanner-symbols.h-g -O2 -pthread -MT libctf_parser_la-ctf-lexer.lo -MD -MP -MF .deps/libctf_parser_la-ctf-lexer.Tpo -c -o libctf_parser_la-ctf-lexer.lotest -f 'ctf-lexer.c' || echo '/home/nathanl/src/babeltrace/build/../formats/ctf/metadata/'ctf-lexer.c
libtool: compile: gcc -DHAVE_CONFIG_H -I/home/nathanl/src/babeltrace/build/.. -I../../.. -I../../../include -includeconfig.h-pthread -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -Wall -Wformat -I/home/nathanl/src/babeltrace/build/../include -includectf-scanner-symbols.h-g -O2 -pthread -MT libctf_parser_la-ctf-lexer.lo -MD -MP -MF .deps/libctf_parser_la-ctf-lexer.Tpo -cctf-lexer.c-fPIC -DPIC -o.libs/libctf_parser_la-ctf-lexer.o
cc1: fatal error:ctf-scanner-symbols.h: No such file or directoryTo recreate, just do something like:
$ ./bootstrap && mkdir build && (cd build && ../configure && make)
Signature · 8 lines
Jérémie Galarneau EfficiOS Inc. http://www.efficios.com _______________________________________________ lttng-dev mailing list [email protected] http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
Quoted 10 lines · Jérémie Galarneau
Hi Nathan,
This should be fixed as of:
commit
d620c28807ba2f9d0b97582384915f6a452a3375Author: Jérémie Galarneau <[email protected]> Date: Fri Oct 16 15:31:28 2015 -0400Fix: missing includes break the out-of-tree build
Quoted 8 lines
Addresses out-of-tree build breakage introduced by commit
3842465694945829d76452ff83924aa0103c6293Reported-by Nathan Lynch <[email protected]>Signed-off-by Jérémie Galarneau <[email protected]>Thanks for reporting!
Jérémie
Hi Sir Galarneau,
I have been investigating a build failure of the babeltrace code on Launchpad, and the following change caught my attention:
-libctf_parser_la_CFLAGS = $(AM_CFLAGS) -include ctf-scanner-symbols.h +libctf_parser_la_CFLAGS = $(AM_CFLAGS)
Is it possible that it was wrongfully included in the aforementioned changeset? It is part of the formats/ctf/metadata/Makefile.am file artifact. Removing it causes the bt_yy_* symbols to go back to yy_* (I don't think that was the intention).
Also, I'll take this opportunity to discuss another part of the
changeset: At a few places, it is possible to use
-I$(srcdir) instead of -I$(top_srcdir)/formats/ctf/metadata
and
-I$(builddir) instead of -I$(top_builddir)/formats/ctf/metadata
This allows one to have less hardcoded path in their build description file. If top_srcdir and top_builddir were willfully chosen, then please ignore this comment.
Best Regards,
Simon Marchi
_______________________________________________
lttng-dev mailing list
[email protected]
http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
Quoted 29 lines · Simon Marchi
Quoted 10 lines · Jérémie Galarneau
Hi Nathan,
This should be fixed as of:
commit
d620c28807ba2f9d0b97582384915f6a452a3375Author: Jérémie Galarneau <[email protected]> Date: Fri Oct 16 15:31:28 2015 -0400Fix: missing includes break the out-of-tree build
Quoted 8 lines
Addresses out-of-tree build breakage introduced by commit
3842465694945829d76452ff83924aa0103c6293Reported-by Nathan Lynch <[email protected]>Signed-off-by Jérémie Galarneau <[email protected]>Thanks for reporting!
JérémieHi Sir Galarneau,
I have been investigating a build failure of the babeltrace code on Launchpad, and the following change caught my attention:
(quoted diff) +1
-1-libctf_parser_la_CFLAGS = $(AM_CFLAGS) -include ctf-scanner-symbols.h +libctf_parser_la_CFLAGS = $(AM_CFLAGS)
Quoted 5 lines
Is it possible that it was wrongfully included in the aforementioned changeset? It is part of the formats/ctf/metadata/Makefile.am file artifact. Removing it causes the bt_yy_* symbols to go back to yy_* (I don't think that was the intention).
My very dear Simon,
That is a very just and astute observation. I'll make sure this part of the change is duly reverted and a comment added to explain the purpose of this explicit include directive.
Quoted 5 lines
Also, I'll take this opportunity to discuss another part of the
changeset: At a few places, it is possible to use-I$(srcdir) instead of -I$(top_srcdir)/formats/ctf/metadata
Quoted 8 lines
and
-I$(builddir) instead of -I$(top_builddir)/formats/ctf/metadataThis allows one to have less hardcoded path in their build description file. If
top_srcdirandtop_builddirwere willfully chosen, then please ignore this comment.
As for the rest of the changes, I propose this patch on top of master [1]. It's the only way I can get the out of tree build to work.
Shall the aforementioned fix not be to your utmost satisfaction, I'll gladly accept an alternative solution as I may have failed to address the problem in the most efficient way.
All the very best,
Sir Galarneau
Quoted 3 lines
Best Regards,
Simon Marchi
Signature · 8 lines
Jérémie Galarneau EfficiOS Inc. http://www.efficios.com _______________________________________________ lttng-dev mailing list [email protected] http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
Quoted 6 lines · Jérémie Galarneau
As for the rest of the changes, I propose this patch on top of master [1]. It's the only way I can get the out of tree build to work.
Shall the aforementioned fix not be to your utmost satisfaction, I'll gladly accept an alternative solution as I may have failed to address the problem in the most efficient way.
The fix you suggest is very much what I had in mind.
Yours truly,
Simon Marchi
_______________________________________________
lttng-dev mailing list
[email protected]
http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev