EDAC: Add ARM64 EDAC
Quoted 8 lines
Quoted 8 lines
Review line 6
Quoted 8 lines
+++
b/drivers/edac/cortex_arm64_edac.c(quoted diff) +6
-0@@ -0,0 +1,457 @@ +/* + * Cortex ARM64 EDAC + * + * Copyright (c) 2015, Advanced Micro Devices + * Author: Brijesh Singh <[email protected]> + *
Hi Brijesh,
Your ARM64 EDAC driver seems rather similar to the existing driver that is linked below. If you have indeed based your driver on this one, can you please provide the appropriate attribution?
Thank you
Steve
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
Hi Steve,
Thanks for pointing the link, I have not seen that driver before; I was mainly looking at driver/edac/xgene_edac.c and some other arm edac drivers. My first attempt was to do AMD specific edac driver to log correctable L1/L2 error but based on feedback I worked on v2 generic driver which now looks very similar to your driver, are you planning to upstream your driver ? I can work with you to verify it on my current hardware setup. It seems your driver also handles single-bit and double-bit error which I have no way to test in my current hardware setup. On Seattle platform most of error handling is done through firmware APEI except correctable L1/L2. Let me know your thoughts.
-Brijesh
________________________________________
From: Stepan Moskovchenko [[email protected]]
Sent: Thursday, October 22, 2015 8:51 PM
To: Singh, Brijeshkumar
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH v2] EDAC: Add ARM64 EDAC
Quoted 16 lines
Quoted 8 lines
Review line 6
Quoted 8 lines
+++
b/drivers/edac/cortex_arm64_edac.c(quoted diff) +6
-0@@ -0,0 +1,457 @@ +/* + * Cortex ARM64 EDAC + * + * Copyright (c) 2015, Advanced Micro Devices + * Author: Brijesh Singh <[email protected]> + *Hi Brijesh,
Your ARM64 EDAC driver seems rather similar to the existing driver that is linked below. If you have indeed based your driver on this one, can you please provide the appropriate attribution?