Skip to contentSkip to conversation

arm: exynos: clean up checkpatch issues

PATCH New Minkyu Kang 1 participant 2 messages Oct 23, 2015 – Nov 2, 2015

Subsystems (3)
Arm (32-bit) Arm sub-architectures Arm Samsung Exynos
lore
Share & tools
lore

Minkyu Kang

author
#0 lore raw

PATCH 1/5 arm: exynos: clean up checkpatch issues

This patch will fix these checkpatch issues.

ERROR: Macros with complex values should be enclosed in parentheses
+#define DEFAULT_DQS_X4 (DEFAULT_DQS << 24) || (DEFAULT_DQS << 16) \
+ || (DEFAULT_DQS << 8) || (DEFAULT_DQS << 0)

ERROR: space prohibited before that ',' (ctx:WxW)
+ writel(val , &drex0->concontrol);
^

ERROR: space prohibited before that ',' (ctx:WxW)

+	writel(val , &drex1->concontrol);
    	           ^
Signed-off-by Minkyu Kang <[email protected]>
---
 arch/arm/mach-exynos/dmc_init_ddr3.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
arch/arm/mach-exynos/dmc_init_ddr3.c +4 -4
index 7c0b12a..25a9df9 100644
@@ -20,8 +20,8 @@
 #define TIMEOUT_US		10000
 #define NUM_BYTE_LANES		4
 #define DEFAULT_DQS		8
-#define DEFAULT_DQS_X4		(DEFAULT_DQS << 24) || (DEFAULT_DQS << 16) \
-				|| (DEFAULT_DQS << 8) || (DEFAULT_DQS << 0)
+#define DEFAULT_DQS_X4		((DEFAULT_DQS << 24) || (DEFAULT_DQS << 16) \
+				|| (DEFAULT_DQS << 8) || (DEFAULT_DQS << 0))
 
 #ifdef CONFIG_EXYNOS5250
 static void reset_phy_ctrl(void)

@@ -856,10 +856,10 @@ int ddr3_mem_ctrl_init(struct mem_timings *mem, int reset)
 	 */
 	val = readl(&drex0->concontrol);
 	val |= CONCONTROL_UPDATE_MODE;
-	writel(val , &drex0->concontrol);
+	writel(val, &drex0->concontrol);
 	val = readl(&drex1->concontrol);
 	val |= CONCONTROL_UPDATE_MODE;
-	writel(val , &drex1->concontrol);
+	writel(val, &drex1->concontrol);
 
 	return 0;
 }
Signature · 5 lines
1.7.9.5

-- 
Thanks,
Minkyu Kang.
author
#1 lore raw

PATCH 1/5 arm: exynos: clean up checkpatch issues

Quoted 14 lines · Minkyu Kang

This patch will fix these checkpatch issues.

ERROR: Macros with complex values should be enclosed in parentheses

(quoted diff) +2 -0
+#define DEFAULT_DQS_X4		(DEFAULT_DQS << 24) || (DEFAULT_DQS << 16) \
+				|| (DEFAULT_DQS << 8) || (DEFAULT_DQS << 0)

ERROR: space prohibited before that ',' (ctx:WxW)

(quoted diff) +1 -0
+	writel(val , &drex0->concontrol);
 	           ^

ERROR: space prohibited before that ',' (ctx:WxW)

(quoted diff) +1 -0
+	writel(val , &drex1->concontrol);
    	           ^
Quoted 5 lines
Signed-off-by Minkyu Kang <[email protected]>
---
 arch/arm/mach-exynos/dmc_init_ddr3.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

applied to u-boot-samsung.

Thanks,
Minkyu Kang.