Skip to contentSkip to conversation

odroid: clean up checkpatch issues

PATCH New Minkyu Kang 1 participant 2 messages Oct 23, 2015 – Nov 2, 2015

lore
Share & tools
lore

Minkyu Kang

author
#0 lore raw

PATCH 4/5 odroid: clean up checkpatch issues

This patch will fix these checkpatch issues.

+static const char *mmc_regulators[] = {

CHECK: Blank lines aren't necessary before a close brace '}' +
+}

Signed-off-by Minkyu Kang <[email protected]>
---
 board/samsung/odroid/odroid.c |   15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)
board/samsung/odroid/odroid.c +7 -8
index 32155f1..36d493d 100644
@@ -33,13 +33,6 @@ enum {
 	ODROID_TYPES,
 };
 
-static const char *mmc_regulators[] = {
-	"VDDQ_EMMC_1.8V",
-	"VDDQ_EMMC_2.8V",
-	"TFLASH_2.8V",
-	NULL,
-};
-
 void set_board_type(void)
 {
 	/* Set GPA1 pin 1 to HI - enable XCL205 output */

@@ -428,6 +421,13 @@ int exynos_init(void)
 
 int exynos_power_init(void)
 {
+	const char *mmc_regulators[] = {
+		"VDDQ_EMMC_1.8V",
+		"VDDQ_EMMC_2.8V",
+		"TFLASH_2.8V",
+		NULL,
+	};
+
 	if (regulator_list_autoset(mmc_regulators, NULL, true))
 		error("Unable to init all mmc regulators");
 

@@ -450,7 +450,6 @@ static int s5pc210_phy_control(int on)
 		return regulator_set_mode(dev, OPMODE_ON);
 	else
 		return regulator_set_mode(dev, OPMODE_LPM);
-
 }
 
 struct s3c_plat_otg_data s5pc210_otg_data = {
Signature · 5 lines
1.7.9.5

-- 
Thanks,
Minkyu Kang.
author
#1 lore raw

PATCH 4/5 odroid: clean up checkpatch issues

Quoted 8 lines · Minkyu Kang

This patch will fix these checkpatch issues.

+static const char *mmc_regulators[] = {

CHECK: Blank lines aren't necessary before a close brace '}'

(quoted diff) +2 -0
+
+}
Quoted 5 lines
Signed-off-by Minkyu Kang <[email protected]>
---
 board/samsung/odroid/odroid.c |   15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

applied to u-boot-samsung.

Thanks,
Minkyu Kang.