Skip to contentSkip to conversation

stmmac: Reporting ethtool_ts_info

DISCUSSION Phil Reid 2 participants 2 messages Oct 27, 2015 – Oct 30, 2015

Subsystems (2)
lore
Share & tools
lore

Phil Reid

author
#0 lore raw

G'day All,

The stmmac driver checks (priv->hwts_tx_en) && (priv->hwts_rx_en) before reporting WHTSTAMP capabilities. No other driver seems to do this. hwts_*_en indicate if timestamping is enabled, not if the interface is capable of it. Instead they check there capabilities. Which would be (priv->dma_cap.time_stamp || priv->dma_cap.atime_stamp)

Does this seem reasonable?

Signature · 2 lines
Regards
Phil Reid
#1 lore raw
Quoted 8 lines · Phil Reid

G'day All,

The stmmac driver checks (priv->hwts_tx_en) && (priv->hwts_rx_en) before reporting WHTSTAMP capabilities.
No other driver seems to do this. hwts_*_en indicate if timestamping is enabled, not if the interface is capable of it.
Instead they check there capabilities. Which would be (priv->dma_cap.time_stamp || priv->dma_cap.atime_stamp)

Yes true.

priv->hwts_*_en indicate if timestamping is enabled/disabled at run time. But priv->dma_cap.time_stamp and priv->dma_cap.atime_stamp indicates HW is support for PTPv1/PTPv2.

We should use - (priv->dma_cap.time_stamp ||
priv->dma_cap.atime_stamp) in ethtool_ts_ops.

wwr
Rayagond

Quoted 12 lines

Does this seem reasonable?

--
Regards
Phil Reid

--
To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html