scsi_sysfs: Fix queue_ramp_up_period return code
Subsystems (2)
PATCH RESEND 1/1 scsi_sysfs: Fix queue_ramp_up_period return code
Writing a number to /sys/bus/scsi/devices/<sdev>/queue_ramp_up_period returns the value of that number instead of the number of bytes written. This behavior can confuse programs expecting POSIX write() semantics. Fix this by returning the number of bytes written instead.
Signed-off-by Peter Oberparleiter <[email protected]>
Reviewed-by Hannes Reinecke <[email protected]>
--- drivers/scsi/scsi_sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/scsi_sysfs.c +1 -1
@@ -898,7 +898,7 @@ sdev_store_queue_ramp_up_period(struct device *dev,return -EINVAL ; sdev->queue_ramp_up_period =msecs_to_jiffies (period); -return period; +return count; } static DEVICE_ATTR(queue_ramp_up_period, S_IRUGO | S_IWUSR,
Signature · 1 line
2.3.0
Quoted 19 lines · Peter Oberparleiter
Writing a number to /sys/bus/scsi/devices/<sdev>/queue_ramp_up_period returns the value of that number instead of the number of bytes written. This behavior can confuse programs expecting POSIX
write()semantics. Fix this by returning the number of bytes written instead.Signed-off-by Peter Oberparleiter <[email protected]>Reviewed-by Hannes Reinecke <[email protected]>---
drivers/scsi/scsi_sysfs.c| 2 +-1 file changed, 1 insertion(+), 1 deletion(-)drivers/scsi/scsi_sysfs.c +0
-0
drivers/scsi/scsi_sysfs.c sdev_store_queue_ramp_up_period(struct device *dev, · line 904
Quoted 8 lines
drivers/scsi/scsi_sysfs.c +1
-1@@ -898,7 +898,7 @@ sdev_store_queue_ramp_up_period(struct device *dev,return -EINVAL ; sdev->queue_ramp_up_period =msecs_to_jiffies (period); -return period; +return count; } static DEVICE_ATTR(queue_ramp_up_period, S_IRUGO | S_IWUSR,
Reviewed-by Matthew R. Ochs <[email protected]>