media: rc: nuvoton-cir: remove unneeded lock

PATCH New Heiner Kallweit 1 participant 1 message Oct 29, 2015

Subsystems (2)

Media (V4L/DVB) RC-core / lirc framework

lore

Share & tools

lore

Heiner Kallweit

author

2015-10-29 21:23 UTC #0 lore raw

PATCH 2/9 media: rc: nuvoton-cir: remove unneeded lock

chip_major / chip_minor are accessed sequentially in probe only. Therefore no lock is needed.

Signed-off-by Heiner Kallweit <[email protected]>

---
 drivers/media/rc/nuvoton-cir.c | 3 ---
 1 file changed, 3 deletions(-)

drivers/media/rc/nuvoton-cir.c +0 -3

index 3d9a4cf..4d8e12f 100644
@@ -227,7 +227,6 @@ static void cir_wake_dump_regs(struct nvt_dev *nvt)
 /* detect hardware features */
 static int nvt_hw_detect(struct nvt_dev *nvt)
 {
-	unsigned long flags;
 	u8 chip_major, chip_minor;
 	char chip_id[12];
 	bool chip_unknown = false;

@@ -279,10 +278,8 @@ static int nvt_hw_detect(struct nvt_dev *nvt)
 
 	nvt_efm_disable(nvt);
 
-	spin_lock_irqsave(&nvt->nvt_lock, flags);
 	nvt->chip_major = chip_major;
 	nvt->chip_minor = chip_minor;
-	spin_unlock_irqrestore(&nvt->nvt_lock, flags);
 
 	return 0;
 }

Signature · 1 line

2.6.2